Skip to content

[TPU][Test] Divide TPU v1 Test into 2 parts. #21431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

QiliangCui
Copy link
Contributor

@QiliangCui QiliangCui commented Jul 23, 2025

Purpose

Separate the large test into 2 and give each a shorter timeout.
TODO: merge the common logic to avoid copy paste after test enabled.

Test Plan

Run on CI.

Test Result

Wait for result.

@mergify mergify bot added the ci/build label Jul 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request splits the TPU v1 tests into two parts to manage test execution time. This was achieved by creating a new script for the second part of the tests and removing them from the original script. While this works, it introduces significant code duplication between the two test scripts. I suggest refactoring to improve maintainability.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@khluu
Copy link
Collaborator

khluu commented Jul 23, 2025

LGTM.. pending on vllm-project/ci-infra#128

Copy link

mergify bot commented Jul 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @QiliangCui.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants