-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[TPU][Test] Divide TPU v1 Test into 2 parts. #21431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request splits the TPU v1 tests into two parts to manage test execution time. This was achieved by creating a new script for the second part of the tests and removing them from the original script. While this works, it introduces significant code duplication between the two test scripts. I suggest refactoring to improve maintainability.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
LGTM.. pending on vllm-project/ci-infra#128 |
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Purpose
Separate the large test into 2 and give each a shorter timeout.
TODO: merge the common logic to avoid copy paste after test enabled.
Test Plan
Run on CI.
Test Result
Wait for result.