-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Bugfix] Fix CUDA arch flags for MoE permute #21426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ming Yang <minos.future@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a critical bug in CMakeLists.txt
by correcting the CUDA architecture flags for the MoE permute kernel, resolving a runtime error. The fix is direct and effective, ensuring the kernel runs on the intended hardware.
SRCS "${MOE_PERMUTE_SRC}" | ||
CUDA_ARCHS "${CUDA_ARCHS}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess someone just copied it over, lol
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the fix.
Purpose
Fix CUDA arch flag for MOE_PERMUTE_SRC.
This resolves the following error
Test Plan
pytest tests/kernels/test_shuffle_rows.py
Test Result
UT passed
(Optional) Documentation Update