Skip to content

[Fix] Update mamba_ssm to 2.2.5 #21421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

elvischenv
Copy link
Contributor

@elvischenv elvischenv commented Jul 23, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

When installing dev requirements via uv pip install -r requirements/dev.txt, mamba-ssm==2.2.4 is failed to install.

  × Failed to build `mamba-ssm==2.2.4`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `setuptools.build_meta.build_wheel` failed (exit status: 1)

Previous WAR for mamba-ssm==2.2.4(#17070, #16859)
Upgrading to mamba-ssm==2.2.5 could root-fix the issue.

Test Plan

Test Result

(Optional) Documentation Update

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jul 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mamba-ssm dependency from version 2.2.4 to 2.2.5 to fix a build failure. The changes in requirements/test.in and the auto-generated requirements/test.txt are correct. However, I've identified a critical issue where docker/Dockerfile still contains hardcoded references to the old, broken version 2.2.4. This will likely cause the dev and test Docker image builds to fail.

@elvischenv elvischenv force-pushed the elvischenv/fix-mamba_ssm-dependency branch from 7db3dff to 2f2f81e Compare July 23, 2025 01:04
@elvischenv elvischenv requested a review from hmellor as a code owner July 23, 2025 01:04
@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 23, 2025
@DarkLight1337
Copy link
Member

cc @tdoublep

Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
@elvischenv elvischenv force-pushed the elvischenv/fix-mamba_ssm-dependency branch from 2f2f81e to 9cf3a81 Compare July 24, 2025 02:09
@elvischenv
Copy link
Contributor Author

Hi @mgoin, do you think we need this update? Thanks

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this change helps simplify our CI/CD

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 24, 2025 07:39
@vllm-bot vllm-bot merged commit 5a19a6c into vllm-project:main Jul 24, 2025
106 of 107 checks passed
@elvischenv elvischenv deleted the elvischenv/fix-mamba_ssm-dependency branch July 24, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants