Skip to content

Add flashinfer_python to CUDA wheel requirements #21389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Jul 22, 2025

Purpose

Test Plan

See if there are any conflicts in CI with the Dockerfile's manual AOT build

Test Result

Signed-off-by: mgoin <mgoin64@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jul 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds flashinfer_python as a dependency for CUDA environments. While this is useful for local development, it introduces a conflict with the existing Docker build process, which builds FlashInfer from source. This leads to a redundant installation and a version mismatch, making the Docker build fragile and potentially incorrect. I've recommended a solution to conditionally exclude this dependency during the Docker build to resolve the conflict.

@mgoin mgoin changed the title Add flashinfer_python by default for CUDA requirements Add flashinfer_python==0.2.8 by default for CUDA requirements Jul 22, 2025
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 22, 2025
@Swipe4057
Copy link

@mgoin mgoin changed the title Add flashinfer_python==0.2.8 by default for CUDA requirements Add flashinfer_python to CUDA wheel requirements Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants