-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Revert "SM100 Cutlass MLA decode with unrestricted num_heads (< 128) for DeepSeek TP" #21019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for Deep…" This reverts commit 8cdc371.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts the changes from PR #20769, which introduced a new SM100 Cutlass MLA decode implementation. The revert appears to be clean and complete, removing the new feature and its related code across the C++, Python, and build system files. The changes correctly restore the previous state of the affected components.
Give me a couple minutes I can push a fix |
#21020 testing it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we have a fix @LucasWilkinson? https://github.com/vllm-project/vllm/pull/21020/files
Thank you for the quick fix, I am testing it locally now @LucasWilkinson |
yes sorry confirmed it works on hopper but waiting for it to build on Blackwell; building this kernel is slowww.... haha edit: Checked |
Reverts #20769
FIX #20769 (comment)