Skip to content

Revert "SM100 Cutlass MLA decode with unrestricted num_heads (< 128) for DeepSeek TP" #21019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Jul 16, 2025

Reverts #20769
FIX #20769 (comment)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the changes from PR #20769, which introduced a new SM100 Cutlass MLA decode implementation. The revert appears to be clean and complete, removing the new feature and its related code across the C++, Python, and build system files. The changes correctly restore the previous state of the affected components.

@jeejeelee jeejeelee requested a review from alexm-redhat July 16, 2025 01:25
@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 16, 2025
@LucasWilkinson
Copy link
Collaborator

Give me a couple minutes I can push a fix

@LucasWilkinson
Copy link
Collaborator

#21020 testing it now

Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeejeelee
Copy link
Collaborator Author

Thank you for the quick fix, I am testing it locally now @LucasWilkinson

@LucasWilkinson
Copy link
Collaborator

LucasWilkinson commented Jul 16, 2025

yes sorry confirmed it works on hopper but waiting for it to build on Blackwell; building this kernel is slowww.... haha

edit:

Checked vllm serve runs when built on hopper
Checked can run VLLM_ATTENTION_BACKEND=CUTLASS_MLA_VLLM_V1 lm_eval --model vllm --model_args pretrained=deepseek-ai/DeepSeek-V2-Lite-Chat,trust_remote_code=true --tasks gsm 8k --batch_size auto

@jeejeelee jeejeelee closed this Jul 16, 2025
@jeejeelee jeejeelee deleted the revert-20769-mla_fi_prefill_and_decode branch July 16, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build deepseek Related to DeepSeek models ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants