Skip to content

[Misc] unify variable for LLM instance #20996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyxning
Copy link
Contributor

@andyxning andyxning commented Jul 15, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Unify LLM instance name to llm instead of model to make it more clear. Improve code readibility.

Test Plan

NA

Test Result

NA

(Optional) Documentation Update

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @andyxning, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code readability and consistency by standardizing the variable name used for vllm.LLM instances. The change involves renaming variables from model or vllm_model to llm throughout the codebase, including documentation, examples, and test files. This refactoring aims to make the code more intuitive and easier to understand for developers.

Highlights

  • Code Readability & Consistency: Standardized the variable name for vllm.LLM instances from model (or vllm_model) to llm across various parts of the codebase, including documentation, examples, and test files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added documentation Improvements or additions to documentation llama Related to Llama models qwen Related to Qwen models v1 labels Jul 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consistently renames the LLM instance variable from model to llm across documentation, examples, and tests, which improves code clarity. I found one instance in docs/features/lora.md that needs to be updated to use the new llm variable.

@andyxning andyxning force-pushed the unify_variable_for_LLM_instance branch from 508cac3 to d1978c3 Compare July 15, 2025 16:13
@andyxning
Copy link
Contributor Author

Code Review

This pull request consistently renames the LLM instance variable from model to llm across documentation, examples, and tests, which improves code clarity. I found one instance in docs/features/lora.md that needs to be updated to use the new llm variable.

Done.

@andyxning andyxning force-pushed the unify_variable_for_LLM_instance branch 2 times, most recently from d708b55 to cc16303 Compare July 16, 2025 02:06
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 16, 2025 02:49
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 16, 2025
auto-merge was automatically disabled July 16, 2025 06:46

Head branch was pushed to by a user without write access

@andyxning andyxning force-pushed the unify_variable_for_LLM_instance branch from cc16303 to 6bb5c9b Compare July 16, 2025 06:46
@mergify mergify bot added multi-modality Related to multi-modality (#4194) speculative-decoding labels Jul 16, 2025
Signed-off-by: Andy Xie <andy.xning@gmail.com>
@andyxning andyxning force-pushed the unify_variable_for_LLM_instance branch from 6bb5c9b to e96128e Compare July 16, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation llama Related to Llama models multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants