-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Allow serving Llama4ForCausalLM directly #20868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sarckk
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
sarckk:llama4-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding the model to the registry is correct, this PR appears to be missing automated tests for the new
Llama4ForCausalLM
model. To ensure the model implementation is and remains correct, please add an entry for it in_TEXT_GENERATION_EXAMPLE_MODELS
intests/models/registry.py
.This will enable CI to run tests against this new architecture. Based on your PR description, you could use
trl-internal-testing/tiny-Llama4ForCausalLM
. If this model is not publicly accessible, consider creating a small, public dummy model with the same architecture for testing purposes.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's no official text-only HF checkpoint, can you add a comment on what's required to enable the text-only version? e.g. Need to change architecture in config.json. Also, does one need to strip the mm part from the HF version? etc.