Skip to content

[Docs] Update supported models documentation with missing models #20844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luccafong
Copy link
Collaborator

Added missing models from registry.py to supported_models.md with accurate example models and feature support information.

@luccafong luccafong requested a review from hmellor as a code owner July 11, 2025 22:07
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @luccafong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on keeping the project's documentation up-to-date by incorporating recently supported models into the supported_models.md file. The changes ensure that users have accurate and comprehensive information regarding available models and their capabilities, improving the overall clarity and utility of the documentation.

Highlights

  • Documentation Update: Added several new model entries to the supported_models.md file, ensuring the documentation reflects the latest supported models from registry.py.
  • New Model Support: Specifically, new entries for Fairseq2LlamaForCausalLM, InternLM2VEForCausalLM, MiMoForCausalLM, and QuantMixtralForCausalLM have been added, complete with example model names and feature support information.
  • Minor Formatting Fix: A small whitespace issue was resolved in the documentation file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@luccafong luccafong changed the title [DOCS] Update supported models documentation with missing models and … [Docs] Update supported models documentation with missing models and … Jul 11, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 11, 2025
@luccafong luccafong changed the title [Docs] Update supported models documentation with missing models and … [Docs] Update supported models documentation with missing models Jul 11, 2025
@luccafong luccafong requested a review from simon-mo July 11, 2025 22:08
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for supported models by adding several new entries. The additions are mostly correct, but I've identified a minor sorting issue in the table and a potential formatting problem due to the removal of trailing whitespace in the footnotes section. My review includes suggestions to address these points to ensure documentation clarity and consistency.

@luccafong luccafong force-pushed the supported-model-update branch from ed4a439 to 66330b4 Compare July 11, 2025 22:15
…feature support

Signed-off-by: Lu Fang <fanglu@fb.com>
@luccafong luccafong force-pushed the supported-model-update branch 2 times, most recently from 7e85b59 to 4152b58 Compare July 11, 2025 22:55
Signed-off-by: Lu Fang <fanglu@fb.com>
@luccafong luccafong force-pushed the supported-model-update branch from 4152b58 to 724b555 Compare July 11, 2025 22:58
@@ -595,6 +599,7 @@ Specified using `--task generate`.
| `Phi3VForCausalLM` | Phi-3-Vision, Phi-3.5-Vision | T + I<sup>E+</sup> | `microsoft/Phi-3-vision-128k-instruct`, `microsoft/Phi-3.5-vision-instruct`, etc. | | ✅︎ | ✅︎ |
| `Phi4MMForCausalLM` | Phi-4-multimodal | T + I<sup>+</sup> / T + A<sup>+</sup> / I<sup>+</sup> + A<sup>+</sup> | `microsoft/Phi-4-multimodal-instruct`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `PixtralForConditionalGeneration` | Pixtral | T + I<sup>+</sup> | `mistralai/Mistral-Small-3.1-24B-Instruct-2503`, `mistral-community/pixtral-12b`, etc. | | ✅︎ | ✅︎ |
| `PrithviGeoSpatialMAE` | Prithvi | I | `ibm-nasa-geospatial/Prithvi-EO-2.0-300M-TL-Sen1Floods11`, etc. | | | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Prithvi is not a text generation model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is image-to-image model. I think only the model vendor is really using this, we should not advertise support for it at this stage because it's far from being optimized.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, let me remove it

@@ -330,6 +330,7 @@ Specified using `--task generate`.
| `Ernie4_5_ForCausalLM` | Ernie4.5 | `baidu/ERNIE-4.5-0.3B-PT`, etc. | | ✅︎ | ✅︎ |
| `Ernie4_5_MoeForCausalLM` | Ernie4.5MoE | `baidu/ERNIE-4.5-21B-A3B-PT`, `baidu/ERNIE-4.5-300B-A47B-PT`, etc. | | ✅︎ | ✅︎ |
| `ExaoneForCausalLM` | EXAONE-3 | `LGAI-EXAONE/EXAONE-3.0-7.8B-Instruct`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `Fairseq2LlamaForCausalLM` | Fairseq2Llama | `mgleize/fairseq2-dummy-Llama-3.2-1B`, etc. | ✅︎ | ✅︎ | ✅︎ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `Fairseq2LlamaForCausalLM` | Fairseq2Llama | `mgleize/fairseq2-dummy-Llama-3.2-1B`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `Fairseq2LlamaForCausalLM` | Llama (fairseq2 format) | `mgleize/fairseq2-dummy-Llama-3.2-1B`, etc. | ✅︎ | ✅︎ | ✅︎ |

cc @houseroad is there a better name to describe this model?

@@ -352,16 +353,19 @@ Specified using `--task generate`.
| `HunYuanMoEV1ForCausalLM` | Hunyuan-80B-A13B | `tencent/Hunyuan-A13B-Instruct`, `tencent/Hunyuan-A13B-Pretrain`, `tencent/Hunyuan-A13B-Instruct-FP8`, etc. | | | ✅︎ |
| `InternLMForCausalLM` | InternLM | `internlm/internlm-7b`, `internlm/internlm-chat-7b`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `InternLM2ForCausalLM` | InternLM2 | `internlm/internlm2-7b`, `internlm/internlm2-chat-7b`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `InternLM2VEForCausalLM` | InternLM2VE | `OpenGVLab/Mono-InternVL-2B`, etc. | ✅︎ | ✅︎ | ✅︎ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `InternLM2VEForCausalLM` | InternLM2VE | `OpenGVLab/Mono-InternVL-2B`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `InternLM2VEForCausalLM` | Mono-InternVL | `OpenGVLab/Mono-InternVL-2B`, etc. | ✅︎ | ✅︎ | ✅︎ |

Copy link
Member

@DarkLight1337 DarkLight1337 Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think this should not be included in the list as it's only meant to be used as text backbone of Mono-InternVL

Signed-off-by: Lu Fang <fanglu@fb.com>
@luccafong luccafong requested a review from DarkLight1337 July 14, 2025 19:37
| `MiniCPMForCausalLM` | MiniCPM | `openbmb/MiniCPM-2B-sft-bf16`, `openbmb/MiniCPM-2B-dpo-bf16`, `openbmb/MiniCPM-S-1B-sft`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `MiniCPM3ForCausalLM` | MiniCPM3 | `openbmb/MiniCPM3-4B`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `MistralForCausalLM` | Mistral, Mistral-Instruct | `mistralai/Mistral-7B-v0.1`, `mistralai/Mistral-7B-Instruct-v0.1`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `MixtralForCausalLM` | Mixtral-8x7B, Mixtral-8x7B-Instruct | `mistralai/Mixtral-8x7B-v0.1`, `mistralai/Mixtral-8x7B-Instruct-v0.1`, `mistral-community/Mixtral-8x22B-v0.1`, etc. | ✅︎ | ✅︎ | ✅︎ |
| `QuantMixtralForCausalLM` | Quantized Mixtral | `mistral-community/Mixtral-8x22B-v0.1-AWQ`, etc. | | ✅︎ | ✅︎ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internally defined model. We list the models on this page by their HF Hub model architecture (which is MixtralForCausalLM in this case) so there is no need to include this as a separate entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants