-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Replace --expand-tools-even-if-tool-choice-none
with --exclude-tools-when-tool-choice-none
for v0.10.0
#20544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @okdshin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a breaking change for v0.10.0 by inverting the default behavior for tool definition inclusion when tool_choice='none'
. It renames the associated command-line argument to reflect this change, removes transitional warnings, and updates documentation to ensure clarity and consistency with the new API design.
Highlights
- API Behavior Change: The default behavior for tool definition inclusion when
tool_choice='none'
has been inverted. Previously, tool definitions were excluded by default to optimize context usage; now, they are included by default, aligning with common LLM API patterns. - Command-Line Argument Renaming: The
--expand-tools-even-if-tool-choice-none
flag, which previously forced tool inclusion, has been renamed to--exclude-tools-when-tool-choice-none
. This new flag explicitly allows users to revert to the old behavior of excluding tools whentool_choice='none'
. - Code Simplification & Deprecation Removal: Transitional warnings and the deprecated flag logic related to the old behavior have been removed, simplifying the codebase and removing temporary constructs introduced for the breaking change.
- Documentation Update: The
docs/features/tool_calling.md
file has been updated to accurately describe the new default behavior fortool_choice='none'
and the correct usage of the renamed command-line argument.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements a breaking change for v0.10.0 by renaming --expand-tools-even-if-tool-choice-none
to --exclude-tools-when-tool-choice-none
and inverting its logic. This makes including tool definitions in the prompt the default behavior when tool_choice="none"
. The changes are consistent across documentation, CLI arguments, and serving logic. The implementation appears correct. I've added one suggestion to improve code clarity in the serving logic.
…ools-when-tool-choice-none` Signed-off-by: okada <kokuzen@gmail.com>
0f53303
to
4fe2231
Compare
f72ad46
to
5de852a
Compare
Follow-up to #17177 implementing the breaking change for v0.10.0.
Changes
--expand-tools-even-if-tool-choice-none
→--exclude-tools-when-tool-choice-none
Migration
Users who need the old behavior can use --exclude-tools-when-tool-choice-none.