[Model] The ForSequenceClassification model should be controlled by override_pooler_config.

[noooop]

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Summary of Changes

Hello @noooop, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test suite to ensure the proper functioning of the override_pooler_config mechanism for sequence classification models. It specifically focuses on validating how the softmax option within the pooler configuration influences the model's classification outputs.

Highlights

• New Test Coverage: I've added a new pytest file (tests/models/language/pooling/test_classification_pooler_config.py) to verify that ForSequenceClassification models correctly respect the override_pooler_config parameter.
• Pooler Configuration Validation: The new test specifically validates the softmax setting within PoolerConfig, asserting that classification outputs differ when softmax is enabled versus disabled, and that applying softmax to the raw output matches the softmax-enabled output.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new test to verify that override_pooler_config is correctly applied to ForSequenceClassification models. The test logic appears sound. I've found a minor issue in the test implementation regarding an assertion, which includes dead code and could be made clearer. My feedback focuses on improving the correctness and maintainability of the test.

[noooop]

@DarkLight1337

after #20527

Bert like ForSequenceClassification, for example, papluca/xlm-roberta-base-language-detection is still not controlled by override_pooler_config.

On the other hand, the model converted using as_seq_cls_model, for example, jason9693/Qwen2.5-1.5B-apeach is controlled by override_pooler_config.

Do we need to unify this?

[DarkLight1337]

Yes, override_pooler_config should be applied in all cases