-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[Core] Implement sleep/wake_up for SpecDecodeWorker #20422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Core] Implement sleep/wake_up for SpecDecodeWorker #20422
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kebe7jun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the ability for the speculative decoding worker to enter and exit a 'sleep' state, effectively managing GPU memory by freeing resources when the model is not actively processing requests and quickly restoring them when needed. This enhancement improves resource utilization, especially in scenarios where the model might be idle for periods.
Highlights
- Sleep/Wake-up Functionality for Speculative Decoding: I've implemented
sleep
andwake_up
methods within theSpecDecodeWorker
class. These methods are crucial for enabling memory management capabilities, allowing the speculative decoding component to release GPU memory when idle and quickly re-allocate it when needed. - Delegation to Proposer Worker: The newly added
sleep
andwake_up
methods inSpecDecodeWorker
delegate their calls directly to theself.proposer_worker
. This indicates that the underlying memory management logic for speculative decoding is handled by the proposer component.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements sleep
and wake_up
functionality for the SpecDecodeWorker
. The implementation delegates these calls only to the proposer_worker
(draft model) but should also call them on the scorer_worker
(target model) to ensure memory is freed correctly.
6ece776
to
b2c6fd3
Compare
b2c6fd3
to
5627cae
Compare
Signed-off-by: Kebe <mail@kebe7jun.com>
5627cae
to
377e8d2
Compare
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Fix #20209 #19400
Purpose
Make sure to enter the sleep state when using speculative decoding.
Test Plan
Make sure that the following script works well.
Test Result
Logs: