-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[WIP][RC] Update PyTorch to 2.8.0 #20358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
huydhn
wants to merge
13
commits into
vllm-project:main
Choose a base branch
from
huydhn:pytorch-2.8.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−46
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d6bf991
[WIP][RC] Update PyTorch to 2.8.0
huydhn 456985c
Handle xformers
huydhn 4838d53
Some more tweaks
huydhn ca21216
Attempt to fix xformers build
huydhn 0c43174
Silly typo
huydhn 14c85d1
Few more tweaks for a greener CI
huydhn ad98d10
Attempt to offload to CPU to avoid OOM in CI
huydhn 316f116
Merge branch 'main' into pytorch-2.8.0
huydhn 460ed09
Merge branch 'main' into pytorch-2.8.0
huydhn 7df288f
Merge branch 'main' into pytorch-2.8.0
huydhn 6a08113
Fix lint
huydhn 44f07c0
Run all test_sequence_parallel again
huydhn 29fb5a0
Typo
huydhn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,7 +95,9 @@ def test_chatglm3_lora_tp4_fully_sharded_loras(chatglm3_lora_files): | |
tensor_parallel_size=4, | ||
trust_remote_code=True, | ||
fully_sharded_loras=True, | ||
enable_chunked_prefill=True) | ||
enable_chunked_prefill=True, | ||
gpu_memory_utilization=0.85, | ||
cpu_offload_gb=10) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. QQ: Why do we need to set There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm getting OOM when running this test. It's unclear if it's related to 2.8 upgrade |
||
output1 = do_sample(llm, chatglm3_lora_files, lora_id=1) | ||
for i in range(len(EXPECTED_LORA_OUTPUT)): | ||
assert output1[i] == EXPECTED_LORA_OUTPUT[i] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a redundancy in how the extra index URL for PyTorch is specified.
The
--extra-index-url
is provided here in thepip-compile
arguments, but it has also been added torequirements/test.in
.The comment in the generated
requirements/test.txt
file indicates that the intended command for regeneration isuv pip compile requirements/test.in ...
without the--extra-index-url
argument, implying it should be read from the.in
file.To maintain a single source of truth and avoid confusion, it would be best to remove the
--extra-index-url
argument from this hook and rely on the definition inrequirements/test.in
. This would make the pre-commit hook's behavior consistent with the documented generation command.