Skip to content

Update registry.py #17762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

AbbottKilig
Copy link

@AbbottKilig AbbottKilig commented May 7, 2025

update registry.py to support Qwen3 Embedding Model

update registry.py to support Qwen3 Embedding Model
Copy link

github-actions bot commented May 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@facebook-github-bot
Copy link

@22quinn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@DarkLight1337
Copy link
Member

Could you elaborate? This shouldn't be necessary since vLLM can automatically use generation models as pooling models.

@AbbottKilig
Copy link
Author

Could you elaborate? This shouldn't be necessary since vLLM can automatically use generation models as pooling models.

If do not and this line code, vllm will load qwen3 using transformers as background. and print log like this:
WARNING 05-07 14:52:12 [utils.py:79] Qwen3ForSequenceClassification has no vLLM implementation, falling back to Transformers implementation. Some features may not be supported and performance may not be optimal.
INFO 05-07 14:52:12 [transformers.py:117] Using Transformers backend.

@mergify mergify bot added the qwen Related to Qwen models label Jun 19, 2025
@mergify mergify bot added the new-model Requests to new models label Jul 11, 2025
Copy link

mergify bot commented Jul 11, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @AbbottKilig.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 11, 2025
@DarkLight1337
Copy link
Member

Closing as superseded by #19260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase new-model Requests to new models qwen Related to Qwen models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants