Skip to content

Separate base model from TransformersModel #15467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2025
Merged

Separate base model from TransformersModel #15467

merged 6 commits into from
Mar 26, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Mar 25, 2025 •
edited by github-actions bot
Loading

Splits TransformersModel into:

  • Base class - TransformersModel
  • LM class - TransformersForCausalLM

This base class can be reused for VLM support by #13754.

@hmellor
Separate base model from TransformersModel
81bf8b1 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 25, 2025
@hmellor hmellor requested a review from Isotr0py March 25, 2025 12:53
Isotr0py
Isotr0py approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just a nit, PTAL!

Isotr0py and others added 3 commits March 26, 2025 00:55
@Isotr0py
fix weight loading
a5024f7 
Signed-off-by: Isotr0py <2037008807@qq.com>
@hmellor
Add supports torch compile
2e666f1 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@Isotr0py
fix lora weights mapping
0ebbc8b 
Signed-off-by: Isotr0py <2037008807@qq.com>
@mergify Mergify
Copy link

mergify bot commented Mar 26, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 26, 2025
@mergify mergify bot removed the needs-rebase label Mar 26, 2025
@Isotr0py
oops
62459de 
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2025
@DarkLight1337 DarkLight1337 merged commit cf5c8f1 into vllm-project:main Mar 26, 2025
48 checks passed
@hmellor hmellor deleted the split-transformers-model branch March 26, 2025 11:02
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @Isotr0py @lulmer
Separate base model from TransformersModel (vllm-project#15467)
0736b04 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @Isotr0py @lk-chen
Separate base model from TransformersModel (vllm-project#15467)
23e0c19 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @Isotr0py @shreyankg
Separate base model from TransformersModel (vllm-project#15467)
42faa0b 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor @Isotr0py
Separate base model from TransformersModel (vllm-project#15467)
c4948ea 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <2037008807@qq.com>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @Isotr0py @DarkLight1337