Skip to content

⬆️ bump base image #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

⬆️ bump base image #328

merged 1 commit into from
Jul 23, 2025

Conversation

joerunde
Copy link
Collaborator

Description

This PR sets the base image to the latest spyre-base drop that now supports compiling models for continuous batching at batch sizes other than 2

Signed-off-by: Joe Runde <joe@joerun.de>
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

Copy link

@rofrano rofrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yannicks1 yannicks1 self-requested a review July 22, 2025 06:43
@joerunde joerunde merged commit 7f07105 into main Jul 23, 2025
19 checks passed
@joerunde joerunde deleted the base-bump branch July 23, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants