Skip to content

[CB][do not merge] Support batch size 1 for decode, simplify warmup #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yannicks1
Copy link
Collaborator

@yannicks1 yannicks1 commented Jul 16, 2025

[CB][do not merge] Support batch size 1 for decode, simplify warmup

As we now switched to torch 2.7.1 in #307 , dynamic dimension of size 1 are supported by torch. Hence, batch size 1 for decode should produce the same graph as batch size >= 2. This PR relaxes the constraint and adapts the warmup. To be tested on the card. if working, this makes #287 redundant.

Signed-off-by: Yannick Schnider <yannick.schnider1@ibm.com>
Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@yannicks1
Copy link
Collaborator Author

bot:test
TEST_FILE=tests/e2e/test_spyre_cb.py MARKERS="spyre"

Signed-off-by: Yannick Schnider <yannick.schnider1@ibm.com>
@yannicks1 yannicks1 changed the title [CB] Support batch size 1 for decode, simplify warmup [CB][do not merge] Support batch size 1 for decode, simplify warmup Jul 16, 2025
@yannicks1
Copy link
Collaborator Author

bot test failed in warmup decode.

Signed-off-by: Yannick Schnider <yannick.schnider1@ibm.com>
@yannicks1
Copy link
Collaborator Author

bot:test
TEST_FILE=tests/e2e/test_spyre_cb.py MARKERS="spyre"

@yannicks1
Copy link
Collaborator Author

Note: CPU failures is expected for BS 1 (didnt adapt warmup as in #287 )

Spyre card: reverting the warmup changes results in a runtime error: compile graph failed

@yannicks1
Copy link
Collaborator Author

Looks like batch size 1 for decode is not supported by the compiler yet... Priority of this is low as performance advantage is marginal paired with a limited use case.

Signed-off-by: Yannick Schnider <yannick.schnider1@ibm.com>
Signed-off-by: Yannick Schnider <yannick.schnider1@ibm.com>
@yannicks1
Copy link
Collaborator Author

update: i tried Joshs suggestion, so far without success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant