Skip to content

[V1][LoRA][Test] V1 Engine LoRA support & e2e test #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

paulyu12
Copy link
Collaborator

What this PR does / why we need it?

Add V1Engine LoRA support.
Add LoRA e2e test on single card and multiple cards.

Does this PR introduce any user-facing change?

How was this patch tested?

jesse996 and others added 2 commits May 17, 2025 21:09
What this PR does / why we need it?
According to this RFC vllm-project#396 and this vllm-project#448, we pull request relavant code to support LoRA in v1 Engine

Does this PR introduce any user-facing change?
Following openai HTTP apis will be supported:
/v1/load_lora_adapter
/v1/unload_lora_adapter

How was this patch tested?
git clone https://github.com/vllm-project/vllm.git
cd vllm/examples/offline_inference/ && python3 multilora_inference.py

Signed-off-by: jesse <szxfml@gmail.com>
Signed-off-by: paulyu <paulyu0307@gmail.com>
paulyu added 5 commits May 19, 2025 09:25
Signed-off-by: paulyu <paulyu0307@gmail.com>
Signed-off-by: paulyu <paulyu0307@gmail.com>
Signed-off-by: paulyu <paulyu0307@gmail.com>
Signed-off-by: paulyu <paulyu0307@gmail.com>
Signed-off-by: paulyu <paulyu0307@gmail.com>
@paulyu12 paulyu12 changed the title V1lora tp2test LoRA test tp=2 May 19, 2025
@paulyu12 paulyu12 changed the title LoRA test tp=2 LoRA e2e test tp=2 May 19, 2025
paulyu and others added 2 commits May 19, 2025 20:26
Signed-off-by: paulyu <paulyu0307@gmail.com>
Signed-off-by: paulyu12 <507435917@qq.com>
@paulyu12 paulyu12 marked this pull request as ready for review May 20, 2025 00:51
@paulyu12 paulyu12 changed the title LoRA e2e test tp=2 [V1][LoRA][Test] V1 Engine LoRA support & e2e test May 20, 2025
@wangxiyuan
Copy link
Collaborator

same as #801. Let's focus on this one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:tests ready read for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants