Skip to content

[BugFix][WIP] Fix accuray problems with deepseek in situation of ep=1, etp>1 #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[BugFix][WIP] Fix accuray problems with deepseek in situation of ep=1, etp>1 #863

wants to merge 3 commits into from
+11 −25

Conversation

whx-sjtu
Copy link
Contributor

This PR tries to fix accuracy problem with deepseek in pure expert-tensor-parallel situation. There are two problems in total:

  1. Fix a bug which incorrectly sets the value of tp_rank when ep_size=1. This code was introduced by @ganyi1996ppo, and I'm not very sure if I can directly delete this code without influencing other funcionalities, especially in data-parallel situation. CC @ganyi1996ppo @yiz-liu
  2. Another problem is related with torch_npu.npu_moe_finalize_routing in fused_experts, and I'm working on solving it.

@ApsarasX ApsarasX mentioned this pull request May 16, 2025
Merged
@MengqingCao MengqingCao mentioned this pull request May 20, 2025
Open
whx-sjtu and others added 2 commits May 20, 2025 22:49
@whx-sjtu
fix etp rank related accuracy problem
a990949 
Signed-off-by: whx-sjtu <2952154980@qq.com>
@zzzzwwjj @whx-sjtu
fix: fix deepseek accuracy when ep_size=1
f05ee46 
Signed-off-by: zzzzwwjj <1183291235@qq.com>
@whx-sjtu
fix ci problems
b23c5fe 
Signed-off-by: whx-sjtu <2952154980@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:ops module:quantization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whx-sjtu @zzzzwwjj