-
Notifications
You must be signed in to change notification settings - Fork 480
[Bugfix]fix_mulit_connector_bug #3332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix a bug in the multi-connector logic. It adjusts how the finished count is determined and adds logic to handle requests that don't require data transfer. While the intent seems correct, there's a critical issue in the implementation regarding duplicated and potentially incorrect method logic that needs to be addressed.
def add_not_transfer_request(self, request_id: str): | ||
with self.done_task_lock: | ||
self.finished_requests.add(request_id) | ||
|
||
def update_done_task_count(self, request_id: str): | ||
with self.done_task_lock: | ||
self.finished_requests.add(request_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added method add_not_transfer_request
is identical to the update_done_task_count
method as shown in the diff at lines 79-81. This code duplication is problematic.
- If they are meant to be identical, please remove one to avoid confusion and maintenance overhead.
- If
update_done_task_count
should have more complex logic (as is often the case for such functions and as suggested by the full file context), then this change might be introducing a critical bug by simplifying it or the diff is misleading.
Please resolve this ambiguity. The current state is confusing and potentially incorrect.
6557766
to
d169adc
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: baxingpiaochong <771405853@qq.com>
d169adc
to
6d1ed59
Compare
What this PR does / why we need it?
When using multi connector, the multi connector does not define get_finished_count, which will cause the kv cache to be released
Does this PR introduce any user-facing change?
How was this patch tested?