Skip to content

[Bugfix] Fix broken CI #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025
Merged

[Bugfix] Fix broken CI #1848

merged 3 commits into from
Jul 17, 2025

Conversation

Potabk
Copy link
Contributor

@Potabk Potabk commented Jul 17, 2025

What this PR does / why we need it?

  • Fix broken commit by #20927
  • Fix broken commit by #20466
  • TODO: more fully adapt to the upstream reconstruction, let's first make CI happy

Does this PR introduce any user-facing change?

How was this patch tested?

Potabk added 2 commits July 17, 2025 07:00
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.18%. Comparing base (ef99fe1) to head (ea366e5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   54.22%   54.18%   -0.05%     
==========================================
  Files          75       74       -1     
  Lines        9244     9235       -9     
==========================================
- Hits         5013     5004       -9     
  Misses       4231     4231              
Flag Coverage Δ
unittests 54.18% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MengqingCao
Copy link
Collaborator

LGTM

Signed-off-by: wangli <wangli858794774@gmail.com>
@wangxiyuan wangxiyuan changed the title [Bugfix] Fix interfaces for upstream changes [Bugfix] Fix broken CI Jul 17, 2025
@wangxiyuan wangxiyuan merged commit f9dfde0 into vllm-project:main Jul 17, 2025
24 checks passed
@Potabk Potabk deleted the bugfix2 branch July 17, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants