Skip to content

[FOLLOWUP] Use base test to avoid patch everwhere #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Jul 6, 2025

What this PR does / why we need it?

Use base test to avoid patch everwhere.

Followup here: #1566

Does this PR introduce any user-facing change?

No

How was this patch tested?

ut ci passed

  • vLLM version: v0.9.2
  • vLLM main: xxxxxx10

Copy link

codecov bot commented Jul 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.33%. Comparing base (c30ddb8) to head (fd3cdbe).
Report is 79 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1634       +/-   ##
===========================================
+ Coverage   27.39%   52.33%   +24.94%     
===========================================
  Files          56       78       +22     
  Lines        6191     9626     +3435     
===========================================
+ Hits         1696     5038     +3342     
- Misses       4495     4588       +93     
Flag Coverage Δ
unittests 52.33% <100.00%> (+24.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yikun Yikun requested a review from wangxiyuan July 6, 2025 07:33
@Yikun Yikun added the ready read for review label Jul 6, 2025
@@ -17,7 +17,7 @@ def __init__(self):
self.deallocate_buffer = MagicMock()


class TestSimpleBuffer(unittest.TestCase):
class TestSimpleBuffer(TestBase):

def setUp(self):
self.pipe = MockSimplePipe()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the supper.setup is needed here.

Copy link
Collaborator Author

@Yikun Yikun Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will confirm soon, I think yes

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@github-actions github-actions bot added merge-conflicts and removed ready read for review labels Jul 15, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants