-
Notifications
You must be signed in to change notification settings - Fork 256
[FOLLOWUP] Use base test to avoid patch everwhere #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
===========================================
+ Coverage 27.39% 52.33% +24.94%
===========================================
Files 56 78 +22
Lines 6191 9626 +3435
===========================================
+ Hits 1696 5038 +3342
- Misses 4495 4588 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -17,7 +17,7 @@ def __init__(self): | |||
self.deallocate_buffer = MagicMock() | |||
|
|||
|
|||
class TestSimpleBuffer(unittest.TestCase): | |||
class TestSimpleBuffer(TestBase): | |||
|
|||
def setUp(self): | |||
self.pipe = MockSimplePipe() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the supper.setup is needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will confirm soon, I think yes
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
Use base test to avoid patch everwhere.
Followup here: #1566
Does this PR introduce any user-facing change?
No
How was this patch tested?
ut ci passed