Skip to content

[BUGFIX] FIX mtp accuraccy when temperture is not 0 #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

JC-ut0
Copy link
Contributor

@JC-ut0 JC-ut0 commented Jul 5, 2025

What this PR does / why we need it?

  1. [BUGFIX] FIX mtp accuraccy when temperture is not 0
  2. [BUGFIX] FIX mtp when multi DP is enabled

Does this PR introduce any user-facing change?

How was this patch tested?

vllm-ascend/tests/long_term/spec_decode_v1/test_v1_mtp_correctness.py

@JC-ut0 JC-ut0 force-pushed the v0.9.1-dev branch 4 times, most recently from 04a266e to b6a0b1f Compare July 7, 2025 06:20
@JC-ut0 JC-ut0 force-pushed the v0.9.1-dev branch 2 times, most recently from d3466e3 to 942eb97 Compare July 7, 2025 12:45
Copy link

github-actions bot commented Jul 8, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: xuyexiong <xuyexiong@huawei.com>
@ganyi1996ppo ganyi1996ppo merged commit e99d232 into vllm-project:v0.9.1-dev Jul 8, 2025
16 checks passed
wanghanqingLYT pushed a commit to raindaywhu/vllm-ascend that referenced this pull request Jul 9, 2025
### What this PR does / why we need it?

1. [BUGFIX] FIX mtp accuraccy when temperture is not 0
2. [BUGFIX] FIX mtp when multi DP is enabled

### Does this PR introduce _any_ user-facing change?


### How was this patch tested?

vllm-ascend/tests/long_term/spec_decode_v1/test_v1_mtp_correctness.py

Signed-off-by: xuyexiong <xuyexiong@huawei.com>
weijinqian0 pushed a commit to weijinqian0/vllm-ascend that referenced this pull request Jul 9, 2025
### What this PR does / why we need it?

1. [BUGFIX] FIX mtp accuraccy when temperture is not 0
2. [BUGFIX] FIX mtp when multi DP is enabled

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

vllm-ascend/tests/long_term/spec_decode_v1/test_v1_mtp_correctness.py

Signed-off-by: xuyexiong <xuyexiong@huawei.com>
Signed-off-by: weijinqian_v1 <weijinqian@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants