Skip to content

[Misc] Code clean up #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jul 4, 2025

  1. move attention mask builder from v0 to common place.
  2. remove some useless function
  3. clean up model_runner_v1

@wangxiyuan wangxiyuan force-pushed the code_clean_up branch 2 times, most recently from cd9c3d2 to c845131 Compare July 4, 2025 10:35
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 97.75281% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.50%. Comparing base (c30ddb8) to head (e65fcea).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/attention/attention.py 50.00% 1 Missing ⚠️
vllm_ascend/attention/attention_mask.py 97.82% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (97.75%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1630       +/-   ##
===========================================
+ Coverage   27.39%   54.50%   +27.10%     
===========================================
  Files          56       82       +26     
  Lines        6191    10001     +3810     
===========================================
+ Hits         1696     5451     +3755     
- Misses       4495     4550       +55     
Flag Coverage Δ
unittests 54.50% <97.75%> (+27.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangxiyuan wangxiyuan force-pushed the code_clean_up branch 3 times, most recently from 894b23f to d619af8 Compare July 7, 2025 06:58
@wangxiyuan wangxiyuan force-pushed the code_clean_up branch 2 times, most recently from c333319 to 0cf349a Compare July 7, 2025 08:20
@wangxiyuan
Copy link
Collaborator Author

wangxiyuan commented Jul 7, 2025

@Yikun @ganyi1996ppo @jianzs please help review. Thanks. This PR is mainly for clear code maintainance

Copy link

github-actions bot commented Jul 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant