Skip to content

[0.9.1][Perf] Optimize the number of rope-related index selections in deepseek. #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

whx-sjtu
Copy link
Contributor

@whx-sjtu whx-sjtu commented Jul 3, 2025

This PR avoids performing index selection of sin/cos cache every layer in deepseek.

@whx-sjtu whx-sjtu changed the title [Perf] Optimize index selection numbers of deepseek rope. [Perf] Optimize the number of rope-related index selections in deepseek. Jul 3, 2025
@whx-sjtu whx-sjtu force-pushed the ds_rope_opt branch 5 times, most recently from cdae151 to 9621b4d Compare July 4, 2025 08:51
Copy link

github-actions bot commented Jul 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@whx-sjtu whx-sjtu force-pushed the ds_rope_opt branch 5 times, most recently from ba98ed2 to ddea987 Compare July 7, 2025 03:50
Signed-off-by: whx-sjtu <2952154980@qq.com>
@wangxiyuan wangxiyuan changed the title [Perf] Optimize the number of rope-related index selections in deepseek. [0.9.1][Perf] Optimize the number of rope-related index selections in deepseek. Jul 7, 2025
@ganyi1996ppo ganyi1996ppo merged commit ea3dc31 into vllm-project:v0.9.1-dev Jul 8, 2025
16 checks passed
@whx-sjtu whx-sjtu deleted the ds_rope_opt branch July 9, 2025 07:10
weijinqian0 pushed a commit to weijinqian0/vllm-ascend that referenced this pull request Jul 9, 2025
… deepseek. (vllm-project#1614)

This PR avoids performing index selection of sin/cos cache every layer
in deepseek.

Signed-off-by: whx-sjtu <2952154980@qq.com>
Signed-off-by: weijinqian_v1 <weijinqian@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants