-
Notifications
You must be signed in to change notification settings - Fork 281
Bump torch version to 2.7.1 #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
04ddefc
to
7bab351
Compare
4f45d58
to
b67e468
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
+ Coverage 65.78% 71.27% +5.49%
==========================================
Files 78 84 +6
Lines 8406 9063 +657
==========================================
+ Hits 5530 6460 +930
+ Misses 2876 2603 -273
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
e113a90
to
f10b808
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Co-authored-by: leo-pony <nengjunma@outlook.com> Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
…h_common.patch_utils Signed-off-by: leo-pony <nengjunma@outlook.com>
…ions now Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
…nt calculating logical to device Signed-off-by: leo-pony <nengjunma@outlook.com>
…ted liberror_manager.so reference Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: leo-pony <nengjunma@outlook.com>
a7efe04
to
2e3f6f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait torch npu 2.7.1 first POC version.
@@ -12,7 +12,6 @@ | |||
# limitations under the License. | |||
# This file is a part of the vllm-ascend project. | |||
# | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change to avoid cherrypick conflict
@@ -193,7 +192,6 @@ std::tuple<at::Tensor, at::Tensor> get_masked_input_and_mask( | |||
size, | |||
loop_cnt, | |||
aiv_num); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change to avoid cherrypick conflict
@@ -178,7 +178,6 @@ std::tuple<at::Tensor, at::Tensor> get_masked_input_and_mask( | |||
int64_t aiv_num = 0; | |||
TORCH_CHECK(aclGetDeviceCapability(device_id, ACL_DEVICE_INFO_VECTOR_CORE_NUM, &aiv_num) == ACL_SUCCESS); | |||
uint32_t loop_cnt = (size + aiv_num - 1) / aiv_num; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change to avoid cherrypick conflict
@@ -42,7 +42,7 @@ By using vLLM Ascend plugin, popular open-source models, including Transformer-l | |||
- Software: | |||
* Python >= 3.9, < 3.12 | |||
* CANN >= 8.1.RC1 | |||
* PyTorch >= 2.5.1, torch-npu >= 2.5.1.post1.dev20250619 | |||
* PyTorch >= 2.7.1, torch-npu >= 2.7.1rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* PyTorch >= 2.7.1, torch-npu >= 2.7.1rc1 | |
* PyTorch >= 2.7.1, torch-npu >= 2.7.1.dev20250724 |
@@ -42,7 +42,7 @@ vLLM 昇腾插件 (`vllm-ascend`) 是一个由社区维护的让vLLM在Ascend NP | |||
- 软件: | |||
* Python >= 3.9, < 3.12 | |||
* CANN >= 8.1.RC1 | |||
* PyTorch >= 2.5.1, torch-npu >= 2.5.1.post1.dev20250619 | |||
* PyTorch >= 2.5.1, torch-npu >= 2.7.1rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* PyTorch >= 2.5.1, torch-npu >= 2.7.1rc1 | |
* PyTorch >= 2.5.1, torch-npu >= 2.7.1.dev20250724 |
"torch-npu==2.5.1.post1.dev20250619", | ||
"torch>=2.5.1", | ||
"torchvision<0.21.0", | ||
"torch-npu==2.7.1rc1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"torch-npu==2.7.1rc1", | |
"torch-npu==2.7.1.dev20250724", |
@@ -24,4 +24,4 @@ numba | |||
# Install torch_npu | |||
--pre | |||
--extra-index-url https://mirrors.huaweicloud.com/ascend/repos/pypi | |||
torch-npu==2.5.1.post1.dev20250619 | |||
torch-npu==2.7.1rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torch-npu==2.7.1rc1 | |
torch-npu==2.7.1.dev20250724 |
@@ -1,4 +1,3 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert unrelated change
@@ -254,16 +254,10 @@ def stateless_init_device_torch_dist_pg( | |||
|
|||
assert is_hccl_available() | |||
|
|||
# TODO(Yizhou): The reason we need to set options while vllm does not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiz-liu FYI, we can finally clean up this, thanks for your note.
Signed-off-by: Yikun Jiang yikunkero@gmail.com
Signed-off-by: leo-pony nengjunma@outlook.com
Replace PR 1527
What this PR does / why we need it?
What this PR does / why we need it?
Bump torch version to 2.7.1
Cleanup 857f489 (#837)
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed
torch-npu 2.7.1rc1 install guide:
https://gitee.com/ascend/pytorch/tree/v2.7.1/
install depending:
install torch-npu: