Skip to content

Add ShouJian Zheng (@jianzs) as vLLM Ascend maintainer #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Jun 13, 2025

What this PR does / why we need it?

Add @jianzs as vLLM Ascend maintainer

@jianzs

I would like to nominate Shoujian Zheng (@jianzs https://github.com/jianzs) as a maintainer, starting with my +1.

  • He focuses on the code quality and good design with solid reviews in P/D disaggregation and DeepSeek improvement area about 30+ high quality review, such as #issuecomment-2811764833, #discussion_r2069927605 and #pullrequestreview-2820996674. This is the most important reason why I nominated him, because helping community developers complete PRs with high quality and continuously ensure the quality of codebase is one of the important responsibilities of a maintainer. We believe he is a great addition.
  • Shoujian's main expertise is distributed inference. He has a lot of experience in production about AI infra. He has very good habits and explains in great detail all changes #issue-3023082580 and share results open: #issuecomment-2853140443. And High quality PR: #706, #774, #852.
  • Community Involvement: Active involved in community discussion, he is collaborative and helps the users solve problems, involved in 30+ PR and issue, such as #issuecomment-2911934292 and #issuecomment-2833523571.

Reference:
[1] https://vllm-ascend.readthedocs.io/en/latest/community/contributors.html
[2] https://vllm-ascend.readthedocs.io/en/latest/community/governance.html

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed with preview

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 13, 2025
@wangxiyuan
Copy link
Collaborator

+1, welcome @jianzs

@ganyi1996ppo
Copy link
Collaborator

welcome @jianzs

@Yikun
Copy link
Collaborator Author

Yikun commented Jun 13, 2025

Thanks all! I added the write permision for @jianzs

image

@Yikun
Copy link
Collaborator Author

Yikun commented Jun 13, 2025

@jianzs Would you mind merging this after your review?

@wangxiyuan
Copy link
Collaborator

wangxiyuan commented Jun 13, 2025

once mergeing the PR, Please remove the picture link in the commit message to make the git log clear. @jianzs

@jianzs
Copy link
Collaborator

jianzs commented Jun 13, 2025

Thanks all! Let's make vLLM-Ascend awesome!

@jianzs jianzs merged commit 94a52cf into vllm-project:main Jun 13, 2025
3 checks passed
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…1203)

### What this PR does / why we need it?

Add @jianzs as vLLM Ascend maintainer

@jianzs
----
I would like to nominate Shoujian Zheng (@jianzs
<https://github.com/jianzs>) as a maintainer, starting with my +1.

- He focuses on the code quality and good design with solid reviews in P/D
disaggregation and DeepSeek improvement area about 30+ high quality review, such
as #issuecomment-2811764833, #discussion_r2069927605 and
#pullrequestreview-2820996674. This is the most important reason why I nominated
him, because helping community developers complete PRs with high quality and
continuously ensure the quality of codebase is one of the important
responsibilities of a maintainer. We believe he is a great addition.
- Shoujian's main expertise is distributed inference. He has a lot of experience
in production about AI infra. He has very good habits and explains in great
detail all changes #issue-3023082580 anqd share results open:
#issuecomment-2853140443. And High quality PR: vllm-project#706, vllm-project#774, vllm-project#852.
- Community Involvement: Active involved in community discussion, he is
collaborative and helps the users solve problems, involved in 30+ PR and issue,
such as #issuecomment-2911934292 and #issuecomment-2833523571.

Reference:
[1] https://vllm-ascend.readthedocs.io/en/latest/community/contributors.html
[2] https://vllm-ascend.readthedocs.io/en/latest/community/governance.html

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…1203)

### What this PR does / why we need it?

Add @jianzs as vLLM Ascend maintainer

@jianzs
----
I would like to nominate Shoujian Zheng (@jianzs
<https://github.com/jianzs>) as a maintainer, starting with my +1.

- He focuses on the code quality and good design with solid reviews in P/D
disaggregation and DeepSeek improvement area about 30+ high quality review, such
as #issuecomment-2811764833, #discussion_r2069927605 and
#pullrequestreview-2820996674. This is the most important reason why I nominated
him, because helping community developers complete PRs with high quality and
continuously ensure the quality of codebase is one of the important
responsibilities of a maintainer. We believe he is a great addition.
- Shoujian's main expertise is distributed inference. He has a lot of experience
in production about AI infra. He has very good habits and explains in great
detail all changes #issue-3023082580 anqd share results open:
#issuecomment-2853140443. And High quality PR: vllm-project#706, vllm-project#774, vllm-project#852.
- Community Involvement: Active involved in community discussion, he is
collaborative and helps the users solve problems, involved in 30+ PR and issue,
such as #issuecomment-2911934292 and #issuecomment-2833523571.

Reference:
[1] https://vllm-ascend.readthedocs.io/en/latest/community/contributors.html
[2] https://vllm-ascend.readthedocs.io/en/latest/community/governance.html

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…1203)

### What this PR does / why we need it?

Add @jianzs as vLLM Ascend maintainer

@jianzs
----
I would like to nominate Shoujian Zheng (@jianzs
<https://github.com/jianzs>) as a maintainer, starting with my +1.

- He focuses on the code quality and good design with solid reviews in P/D
disaggregation and DeepSeek improvement area about 30+ high quality review, such
as #issuecomment-2811764833, #discussion_r2069927605 and
#pullrequestreview-2820996674. This is the most important reason why I nominated
him, because helping community developers complete PRs with high quality and
continuously ensure the quality of codebase is one of the important
responsibilities of a maintainer. We believe he is a great addition.
- Shoujian's main expertise is distributed inference. He has a lot of experience
in production about AI infra. He has very good habits and explains in great
detail all changes #issue-3023082580 anqd share results open:
#issuecomment-2853140443. And High quality PR: vllm-project#706, vllm-project#774, vllm-project#852.
- Community Involvement: Active involved in community discussion, he is
collaborative and helps the users solve problems, involved in 30+ PR and issue,
such as #issuecomment-2911934292 and #issuecomment-2833523571.

Reference:
[1] https://vllm-ascend.readthedocs.io/en/latest/community/contributors.html
[2] https://vllm-ascend.readthedocs.io/en/latest/community/governance.html

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
momo609 pushed a commit to momo609/vllm-ascend that referenced this pull request Jun 17, 2025
…project#1203)"

This reverts commit 70864b6.

Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
songshanhu07 added a commit to songshanhu07/vllm-ascend that referenced this pull request Jun 17, 2025
…to main

* 'main' of https://github.com/vllm-project/vllm-ascend: (22 commits)
  [Bugfix] Remove cuda related lines and add additional pip mirror (vllm-project#1252)
  [refactor] Refactoring AscendFusedMoE (vllm-project#1229)
  [Doc] Refactor and init user story page  (vllm-project#1224)
  [Doctest] add installation doctest (vllm-project#1179)
  [DP][V1] Fix rank set in DP scenario & Bump torch-npu version to 2.5.1.post1.dev20250528 (vllm-project#1235)
  Fix the device error when using ray as vllm-acend backend (vllm-project#884)
  [CI] Add unit test framework (vllm-project#1201)
  [Build] Speedup image build (vllm-project#1216)
  [CI] Make e2e test to be preemptible and simple (vllm-project#1217)
  Waiting for BMM NZ support(Improve TPOP 2ms performance)  (vllm-project#1131)
  [Doc] fix VLLM_USE_V1 value in graph mode docs (vllm-project#1226)
  vllm-ascend support chunked prefill (vllm-project#1172)
  [CI/UT][Graph] Add ut for torchair graph mode (vllm-project#1103)
  Add ShouJian Zheng (@jianzs) as vLLM Ascend maintainer (vllm-project#1203)
  [CI] Recover ut for ascend scheduler only in ci of v1. (vllm-project#1180)
  Support multistream of MLA vector operations (vllm-project#1135)
  [Doc] Add Referer header for CANN package download url. (vllm-project#1192)
  [fix] fix bug in 1p1d disaggregated_prefill example (vllm-project#1184)
  [CI][Benchmark] Add qwen2.5-7b test (vllm-project#1104)
  [CI][Benchmark] Add new model and v1 test to perf benchmarks (vllm-project#1099)
  ...
Sync with upstream main branch# the commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants