-
Notifications
You must be signed in to change notification settings - Fork 179
[Examples] Remote trust_remote_code
from people's speech dataset
#1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the Whisper example to align with recent changes in the datasets
library. Specifically, it removes an outdated and unsupported parameter from the dataset loading call, resolving a warning and ensuring compatibility with newer versions of the library.
Highlights
- Dataset Loading Update: Removed the
trust_remote_code
parameter from thepeoples_speech
dataset loading in the Whisper example. This change addresses a warning issued by thedatasets
library (version 4.0.0 and above) which no longer supports remote code execution via this parameter.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request removes the deprecated trust_remote_code
argument from a dataset loading call. However, the change may break the example script if the dataset still relies on a remote loading script. Consider updating the script to use a compatible dataset.
DATASET_ID, | ||
DATASET_SUBSET, | ||
split=f"{DATASET_SPLIT}[:{NUM_CALIBRATION_SAMPLES}]", | ||
trust_remote_code=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing trust_remote_code=True
may cause the load_dataset
call to fail. The MLCommons/peoples_speech
dataset may still rely on a remote loading script, which is no longer supported by default in recent versions of the datasets
library. Consider using a dataset that does not require a remote loading script, or revert this change until the dataset is updated to a compatible format.
Purpose
trust_remote_code
option from peoples_speech dataset loading in whisper exampledatasets
warningBackground
As of datasets==4.0.0, datasets with remote code are no longer supported
Changes
trust_remote_code_data
from data loading in whisper example