Fix preserved state across OpenAI requests when backend_body / backend_params are used #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a state preservation issue where modifications to backend_body/backend_params were being shared across multiple OpenAI requests due to mutable dictionary references. The fix ensures each request gets an independent copy of the extra body configuration.
- Adds deep copying of extra_body dictionaries to prevent shared mutable state
- Imports the copy module to support the deepcopy functionality
sjmonson
approved these changes
Jul 22, 2025
…d_params are used Signed-off-by: Mark Kurtz <mark.j.kurtz@gmail.com>
To clarify all of the UI changes here, there was a previous version of the UI that worked with an older version of guidellm and the code used to generate the html report provided the UI with a different data format. Most of the UI changes here are needed to get things up to date with the current version of guidellm and how the html reporting logic generates data. There are a few specific changes in these files to get logarithmic scaling working which I found was broken after making these changes, in hindsight I would have split these out into another PR: src/ui/lib/components/Charts/DashedLine/DashedLine.component.tsx src/ui/lib/components/Charts/DashedLine/helpers.ts src/ui/lib/components/Charts/MetricLine/MetricLine.component.tsx tests/ui/unit/components/Charts/DashedLine/helpers.test.ts There were a few other tiny bug fixes as well. --------- Signed-off-by: dalthecow <dalcowboiz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Samuel Monson <smonson@redhat.com> Co-authored-by: Mark Kurtz <mark.j.kurtz@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Mark Kurtz <mark.j.kurtz@gmail.com>
markurtz
force-pushed
the
bug/max-always-forced
branch
from
59d4e84 to
1ddf2b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.