Lock pydantic to latest version #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
sjmonson
approved these changes
Jul 15, 2025
DaltheCow
pushed a commit
that referenced
this pull request
Jul 15, 2025
Based on #221, there are pydantic bugs that affect the use of GuideLLM. This PR sets PyDantic to the latest major and patch version because that is the version that is least likely to cause problems for users. If there is a specific reason to use a lower version, more time would need to be spent testing old versions and figuring out what version fixed the problem demonstrated in #221 I checked and this version still supports Python 3.9+. Closes #221 Signed-off-by: Jared O'Connell <joconnel@redhat.com> Signed-off-by: dalthecow <dalcowboiz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #221, there are pydantic bugs that affect the use of GuideLLM.
This PR sets PyDantic to the latest major and patch version because that is the version that is least likely to cause problems for users. If there is a specific reason to use a lower version, more time would need to be spent testing old versions and figuring out what version fixed the problem demonstrated in #221
I checked and this version still supports Python 3.9+.
Closes #221