Skip to content

implement html output, fix log scaling in charts #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DaltheCow
Copy link
Contributor

@DaltheCow DaltheCow commented Jul 1, 2025

To clarify all of the UI changes here, there was a previous version of the UI that worked with an older version of guidellm and the code used to generate the html report provided the UI with a different data format. Most of the UI changes here are needed to get things up to date with the current version of guidellm and how the html reporting logic generates data.

There are a few specific changes in these files to get logarithmic scaling working which I found was broken after making these changes, in hindsight I would have split these out into another PR:
src/ui/lib/components/Charts/DashedLine/DashedLine.component.tsx
src/ui/lib/components/Charts/DashedLine/helpers.ts
src/ui/lib/components/Charts/MetricLine/MetricLine.component.tsx
tests/ui/unit/components/Charts/DashedLine/helpers.test.ts

There were a few other tiny bug fixes as well.

@DaltheCow DaltheCow added the UI Front-end workstream label Jul 1, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16010163088/artifacts/3444433981.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16010161293/artifacts/3444434269.
They will be retained for up to 30 days.

Copy link

github-actions bot commented Jul 1, 2025

🎉 Live Preview: Click here to view the live version
Last updated: 5334bb4

github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16128343191/artifacts/3480921434.
They will be retained for up to 30 days.

github-actions bot pushed a commit that referenced this pull request Jul 7, 2025
Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice any major red flags from the code review.
I took the time to run a new benchmark using this branch, since the output format changed from the addition of the 50th percentile. I merged in my from-file changes for testing, and converted the JSON output to HTML, and I encountered two things.

First, I got these warnings:

Saving benchmarks report...
/Users/joconnel/Documents/projects/ai/guidellm/.venv/lib/python3.13/site-packages/pydantic/main.py:463: UserWarning: Pydantic serializer warnings:
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p50', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p90', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p95', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p99', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p50', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p90', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p95', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p99', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p50', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p90', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p95', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p99', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p50', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p90', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p95', input_type=str])
  PydanticSerializationUnexpectedValue(Expected `float` - serialized value may not be as expected [input_value='p99', input_type=str])
  return self.__pydantic_serializer__.to_python(
Benchmarks report saved to benchmarks_html.html

Second, the HTML file displays nearly blank. I'll upload my benchmarks file for comparison. It's possible that I did something wrong. The HTML cannot be included in this comment, so here is a picture of the output on Firefox:
image
benchmarks_html.json

Base automatically changed from ui-build-pipeline-and-ci to main July 10, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Front-end workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants