[Hotfix] Implement method on dense compressor #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
rahul-tuli
reviewed
Jun 9, 2025
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
brian-dellabetta
approved these changes
Jun 10, 2025
kylesayrs
added a commit
to vllm-project/llm-compressor
that referenced
this pull request
Jun 10, 2025
## Purpose ## * Fix example failure where sparsity stats were attempted to be computed on a compressed model * This happened because the `get_model_compressor` cannot compute sparsity stats of a compressed model ## Prerequisites ## * vllm-project/compressed-tensors#345 ## Changes ## * When saving checkpoints, call `get_model_compressor` on the decompressed model (before it is compressed, not after) * Do not save checkpoints with sparsity stats by default, due to high runtime ## Testing ## * Ran example to completion with reduced training duration Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
aireilly
pushed a commit
to aireilly/llm-compressor
that referenced
this pull request
Jul 30, 2025
…-project#1528) ## Purpose ## * Fix example failure where sparsity stats were attempted to be computed on a compressed model * This happened because the `get_model_compressor` cannot compute sparsity stats of a compressed model ## Prerequisites ## * vllm-project/compressed-tensors#345 ## Changes ## * When saving checkpoints, call `get_model_compressor` on the decompressed model (before it is compressed, not after) * Do not save checkpoints with sparsity stats by default, due to high runtime ## Testing ## * Ran example to completion with reduced training duration Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Etelis
added a commit
to Etelis/compressed-tensors
that referenced
this pull request
Sep 11, 2025
* swap to dense Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> * update docstring Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> --------- Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DenseCompressor, not theBaseSparseCompressorDenseCompressoris in thesparse_compressorsfolder, but does not inherit fromBaseSparseCompressor