Several Bug Fixes needed while building my trading bot. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Noiw preview orders work for Multileg.
… allow for a proxy server to intercept all the requests and responses to record them to a file for debugging and writing unit tests.
…s. I spent a while trying to figure out what was wrong until running the PUT quest using PostMan and then getting a clear error message that the order was in the wrong state. This will give better error information of what's wrong, right away.
tigerdarling
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now preview orders work for Multileg.
The MultiLeg order wasn't setting the preview: true
flag in the JSON.
Also added another constructor for TradierClient
And then fixed the 401 BadRequest error handling
to show the error message from Tradier for easier
debugging of issues.