Skip to content

Refactor file handling to use 'with' statement #9500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

allrob23
Copy link
Contributor

@allrob23 allrob23 commented Mar 5, 2025

Closes #9499

Change List

  • Refactored the file handling in bindings/pydeck/tests/fixtures.py to use the with open() statement.

@allrob23 allrob23 changed the title Refactor File Handling to Use 'with' Statement Refactor file handling to use 'with' statement Mar 6, 2025
@felixpalmer felixpalmer requested a review from donmccurdy March 12, 2025 10:36
Copy link
Collaborator

@felixpalmer felixpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear many other places in the python code that use open without with. I'm not against this change, but if you're going to fix it in one place, can you fix it in all files - so the usage is consistent?

@allrob23
Copy link
Contributor Author

Ok. I will do that.

@allrob23
Copy link
Contributor Author

I have updated all occurrences where open was used without with across all files to ensure consistency. Let me know if you need any further adjustments.

@allrob23
Copy link
Contributor Author

Hey @felixpalmer, just following up to see if you might have a chance to review this.
Appreciate your time!

@coveralls
Copy link

coveralls commented May 5, 2025

Coverage Status

coverage: 91.634%. remained the same
when pulling 7385ee0 on allrob23:master
into b1e4a9f on visgl:master.

@chrisgervang chrisgervang merged commit 19961a1 into visgl:master May 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Improve File Handling in fixtures.py
4 participants