🐛 Fix lambda.unregister incorrectly removing non-lambda methods #283

Milly · 2025-06-08T10:12:28Z

Previously, lambda.unregister could unintentionally delete non-lambda methods of the dispatcher. This commit ensures that only methods with IDs beginning with "lambda:" are unregistered, and that passing a non-lambda method ID will do nothing and return false.

Summary by CodeRabbit

Bug Fixes
- Improved the unregister process to prevent accidental removal of non-lambda functions.
Tests
- Enhanced test coverage for unregistering both valid and invalid lambda identifiers, ensuring correct behavior and reliability.

Previously, lambda.unregister could unintentionally delete non-lambda methods of the dispatcher. This commit ensures that only methods with IDs beginning with "lambda:" are unregistered, and that passing a non-lambda method ID will do nothing and return false. Additional tests have been added to verify this behavior.

coderabbitai · 2025-06-08T10:12:34Z

Walkthrough

The unregister function in the lambda module was updated to include a type guard that ensures only lambda-registered function IDs (those starting with "lambda:") can be unregistered. Corresponding tests were added and refined to verify this behavior, ensuring that non-lambda IDs are not unregistered.

Changes

File(s)	Change Summary
lambda/mod.ts	Added `isRegisteredFnId` type guard; updated `unregister` to check ID format before deleting from dispatcher.
lambda/mod_test.ts	Enhanced and added tests to verify that only IDs with "lambda:" prefix can be unregistered.

Poem

In the warren of code, a check was born,
To guard the lambdas, both dusk and morn.
Only those with "lambda:" may leave,
While imposters must quietly weave.
With tests in tow, the logic is sound—
The rabbits rejoice, their functions still bound!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f8e7f4 and 1ea9c44.

📒 Files selected for processing (2)

lambda/mod.ts (2 hunks)
lambda/mod_test.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: test (macos-latest, 1.x, v9.1.0448, v0.10.0)
GitHub Check: test (ubuntu-latest, 1.x, v9.1.0448, v0.10.0)
GitHub Check: test (ubuntu-latest, 1.45.0, v9.1.0448, v0.10.0)
GitHub Check: test (macos-latest, 1.45.0, v9.1.0448, v0.10.0)
GitHub Check: test (windows-latest, 1.45.0, v9.1.0448, v0.10.0)
GitHub Check: test (windows-latest, 1.x, v9.1.0448, v0.10.0)

🔇 Additional comments (5)

lambda/mod.ts (2)

146-146: LGTM! Proper type guard implementation.

The addition of isRegisteredFnId(id) check correctly prevents unregistering non-lambda methods. This ensures only identifiers starting with "lambda:" can be unregistered, addressing the bug described in the PR objectives.

297-299: Well-implemented type guard function.

The isRegisteredFnId function correctly validates lambda identifiers by checking both type and prefix. The implementation is concise and serves as an effective type guard.

lambda/mod_test.ts (3)

153-153: Good alignment with new validation logic.

The test now uses a properly formatted lambda ID ("lambda:not-registered-id") which aligns with the new validation logic in the unregister function. This ensures the test verifies the correct behavior path.

164-168: Consistent test structure for return value validation.

The test correctly verifies that unregister returns false for unregistered lambda IDs, maintaining consistency with the existing test patterns.

170-194: Comprehensive test coverage for the new behavior.

This test suite thoroughly validates the new type guard functionality:

Verifies that non-lambda methods remain untouched when unregister is called with non-lambda IDs

Confirms the method remains callable after the unregister attempt

Validates that unregister returns false for non-lambda IDs

The test design properly isolates the dispatcher to contain only the test method, ensuring clean test conditions.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-08T10:14:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (5f8e7f4) to head (1ea9c44).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   85.80%   85.81%   +0.01%     
==========================================
  Files          65       65              
  Lines        3458     3461       +3     
  Branches      301      301              
==========================================
+ Hits         2967     2970       +3     
  Misses        489      489              
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Milly requested a review from lambdalisue June 8, 2025 10:14

lambdalisue approved these changes Jun 9, 2025

View reviewed changes

lambdalisue merged commit b875e8c into main Jun 9, 2025
10 checks passed

lambdalisue deleted the lambda-unregister-correctly branch June 9, 2025 03:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 Fix lambda.unregister incorrectly removing non-lambda methods #283

🐛 Fix lambda.unregister incorrectly removing non-lambda methods #283

Uh oh!

Milly commented Jun 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 8, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jun 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

🐛 Fix lambda.unregister incorrectly removing non-lambda methods #283

🐛 Fix lambda.unregister incorrectly removing non-lambda methods #283

Uh oh!

Conversation

Milly commented Jun 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jun 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Milly commented Jun 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 8, 2025 •

edited

Loading