without custom code, CRA service doing cache work

vigneshwaran-chandrasekaran · vigneshwaran-chandrasekaran · commit 7a3b2fe9a1af · 2020-07-23T23:23:50.000+05:30
diff --git a/public/index.html b/public/index.html
@@ -36,7 +36,7 @@
       To begin the development, run `npm start` or `yarn start`.
       To create a production bundle, use `npm run build` or `yarn build`.
     --></body>
-	<script>
+	<!-- <script>
 		if ('serviceWorker' in navigator) {
 			window.addEventListener('load', () => {
 				console.log('serviceWorker custom');
@@ -46,5 +46,5 @@
 					.catch((err) => console.log('Failure: ', err));
 			});
 		}
-	</script>
+	</script> -->
 </html>
diff --git a/public/my-serviceworker.js b/public/my-serviceworker.js
@@ -2,8 +2,9 @@ const CACHE_NAME = 'version-1';
 const urlsToCache = [
 	'index.html',
 	'offline.html',
-	'https://todo-restapi-app.herokuapp.com/api/todos?all=true',
+	'https://todo-restapi-app.herokuapp.com/api/todos',
 	'/todo',
+	'https://todo-restapi-app.herokuapp.com/api/',
 ];
 
 const self = this;
diff --git a/public/offline.html b/public/offline.html
@@ -3,7 +3,7 @@
 	<head>
 		<meta charset="UTF-8" />
 		<meta name="viewport" content="width=device-width, initial-scale=1.0" />
-		<title>Weather App</title>
+		<title>Todo App</title>
 		<style type="text/css">
 			html {
 				height: 100%;
diff --git a/src/index.js b/src/index.js
@@ -21,4 +21,4 @@ ReactDOM.render(
 // If you want your app to work offline and load faster, you can change
 // unregister() to register() below. Note this comes with some pitfalls.
 // Learn more about service workers: https://bit.ly/CRA-PWA
-serviceWorker.unregister();
+serviceWorker.register();
