unregister code changed

vigneshwaran-chandrasekaran · vigneshwaran-chandrasekaran · commit edd02fca01be · 2020-07-23T20:07:23.000+05:30
diff --git a/public/index.html b/public/index.html
@@ -7,13 +7,11 @@
 		<meta name="theme-color" content="#000000" />
 		<meta name="description" content="Todo App" />
 		<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
-		<!-- <link rel="apple-touch-icon" href="./logo192.png" /> -->
 		<!--
       manifest.json provides metadata used when your web app is installed on a
       user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
     -->
 		<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
-		<!-- <link rel="manifest" href="./manifest.json" /> -->
 		<!--
       Notice the use of %PUBLIC_URL% in the tags above.
       It will be replaced with the URL of the `public` folder during the build.
@@ -41,10 +39,9 @@
 	<script>
 		if ('serviceWorker' in navigator) {
 			window.addEventListener('load', () => {
+				console.log('serviceWorker custom');
 				navigator.serviceWorker
-					.register('./serviceworker.js', {
-						// scope: '.', // <--- THIS BIT IS REQUIRED
-					})
+					.register('./my-serviceworker.js')
 					.then((reg) => console.log('Success: ', reg.scope))
 					.catch((err) => console.log('Failure: ', err));
 			});
diff --git a/public/manifest.json b/public/manifest.json
@@ -1,6 +1,6 @@
 {
-  "short_name": "Todo App",
-  "name": "Todo App PWA",
+  "short_name": "Todo app v2",
+  "name": "Todo app PWA v2",
   "icons": [
     {
       "src": "favicon.ico",
diff --git a/public/my-serviceworker.js b/public/my-serviceworker.js
@@ -1,5 +1,10 @@
 const CACHE_NAME = 'version-1';
-const urlsToCache = ['index.html', 'offline.html'];
+const urlsToCache = [
+	'index.html',
+	'offline.html',
+	'https://todo-restapi-app.herokuapp.com/api/todos?all=true',
+	'/todo',
+];
 
 const self = this;
 
diff --git a/public/offline.html b/public/offline.html
@@ -37,7 +37,7 @@
 	<body>
 		<div class="city">
 			<h2 class="city-name">
-				<span>Please go to online.</span>
+				<span>Please go to online 1.</span>
 			</h2>
 		</div>
 	</body>
diff --git a/src/index.js b/src/index.js
@@ -21,4 +21,4 @@ ReactDOM.render(
 // If you want your app to work offline and load faster, you can change
 // unregister() to register() below. Note this comes with some pitfalls.
 // Learn more about service workers: https://bit.ly/CRA-PWA
-serviceWorker.register();
+serviceWorker.unregister();

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`		`- "short_name": "Todo App",`
`3`		`- "name": "Todo App PWA",`
	`2`	`+ "short_name": "Todo app v2",`
	`3`	`+ "name": "Todo app PWA v2",`
`4`	`4`	`"icons": [`
`5`	`5`	`{`
`6`	`6`	`"src": "favicon.ico",`