gpu/pass.rs: Remove Iterator::collect<Vec<_>> usage from bind calls #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I disliked that trivial resource bind calls were performing memory allocations, so I changed the
gpu
API.However, I want you to take a moment to discuss whether the API should have a newtype for
*mut SDL_GPUBuffer
that is used for asys
-crate bind-call, just like it has one forSDL_GPUBufferBinding
andSDL_GPUTextureSamplerBinding
.In my opinion, there should be an opaque newtype for that, and the API shouldn't just use the raw pointer that can be obtained from
Buffer::raw()
andTexture::raw()
.