Prevent form submission during IME composition #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add composition event handlers to PromptInputTextarea to prevent premature form submission when users press Enter to confirm IME input (e.g., Japanese, Chinese, Korean). The component now tracks composition state explicitly using onCompositionStart and onCompositionEnd events, in addition to checking the native isComposing property. This fixes an issue where Japanese users typing with an IME would accidentally submit the form when pressing Enter to convert kanji, instead of just confirming the conversion. Signed-off-by: Sora Morimoto <sora@morimoto.io>
|
@smorimoto is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Nice one, thanks @smorimoto 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes form submission during IME composition in
PromptInputTextarea.Problem
When users type in Japanese (or other languages requiring IME), pressing Enter to confirm character conversion would incorrectly submit the form instead of just completing the conversion. This made the input field difficult to use for CJK language users.
Solution
Added explicit composition state tracking using:
onCompositionStart: SetsisComposingtotrueonCompositionEnd: SetsisComposingtofalsehandleKeyDownto check both the localisComposingstate ande.nativeEvent.isComposingThis ensures the Enter key during composition is handled by the IME, not the form submission logic.
Testing
Related