-
Notifications
You must be signed in to change notification settings - Fork 4
Improved heading detection by adding isolated bold case #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaximPlusov
merged 3 commits into
veraPDF:integration
from
hnc-leebd:improve/heading-detection
Sep 25, 2025
Merged
Improved heading detection by adding isolated bold case #349
MaximPlusov
merged 3 commits into
veraPDF:integration
from
hnc-leebd:improve/heading-detection
Sep 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximPlusov
requested changes
Sep 25, 2025
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
hnc-leebd
commented
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will push the revised commit.
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/verapdf/wcag/algorithms/semanticalgorithms/utils/NodeUtils.java
Outdated
Show resolved
Hide resolved
4fc1dd2 to
4abd0fc
Compare
4abd0fc to
ce5cccd
Compare
|
@MaximPlusov |
MaximPlusov
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the dataloader, I added a case that detects titles with the same font name, a large font size, and bold style, which are occasionally seen in papers.
Since bold style already receives bonus points for properness, I added logic to determine if a short, single-line text node is isolated and assign bonus points.
This logic requires determining the bounding box, which involves expanding the overall test code.