Separate cli and gui

[MaximPlusov]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 18.33%. Comparing base (477c02e) to head (1756d25).
Report is 33 commits behind head on integration.

Files with missing lines	Patch %	Lines
...src/main/java/org/verapdf/cli/FormatterHelper.java	0.00%	5 Missing ⚠️
...ava/org/verapdf/cli/commands/VeraCliArgParser.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##             integration     #415       +/-   ##
==================================================
+ Coverage           0.00%   18.33%   +18.33%     
- Complexity             0       48       +48     
==================================================
  Files                  2        8        +6     
  Lines                  8      709      +701     
  Branches               0      107      +107     
==================================================
+ Hits                   0      130      +130     
- Misses                 8      562      +554     
- Partials               0       17       +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hueldoeu]

how can i install veraPDF with the help of winget?

[bdoubrov]

@hueldoeu the veraPDF installer is based on izPack, which is a generic Java-based installer. It does into include WinGet manifest. There is however a way to install veraPDF from command line as described here: https://docs.verapdf.org/install/#automated-installation

BTW, your question doesn't seem to be related to this particular PR. If this is indeed the case, it would be better to post an issue in veraPDF-library repository.

[carlwilson]

So I like this all in all. I do have some comments as to the final build products and installer behaviour, but they're optimisations.

I'm not in love with the two fat jars approach, I know that we mentioned it in the call. This means a full install's bin directory looks like:

total 18M
drwxr-xr-x 2 cfw cfw 4.0K Jun 13 10:37 .
drwxr-xr-x 7 cfw cfw 4.0K Jun 13 10:37 ..
-rwxr-xr-x 1 cfw cfw 8.7M Jun 13 10:11 cli-1.29.0-SNAPSHOT.jar
-rwxr-xr-x 1 cfw cfw 8.9M Jun 13 10:11 gui-1.29.0-SNAPSHOT.jar

Nearly twice as big as before. I think we need to break the jars/modules apart for deployment. I'd also be interested to see what gets deployed to Maven, but we can review then.

My only other observation is regarding installation and clean-up. If you install on top of an old installation and change between CLI/GUI the jars in the bin directory get "cleaned" by the installer, i.e. installing the CLI will remove any existing GUI jar and vice-versa. The installer doesn't tidy up the corresponding script files so you are left with a "broken" verapdf-gui script:

$ ./verapdf-gui
Error: Could not find or load main class org.verapdf.apps.GreenfieldGuiWrapper
Caused by: java.lang.ClassNotFoundException: org.verapdf.apps.GreenfieldGuiWrapper

We should remove the unused script as well if possible, this could perhaps be done before merging.