Skip to content

fix(aws_ecs_metrics source): skip over empty ECS metrics payloads #23151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jun 4, 2025

Summary

The ECS metrics endpoint can produce null or empty objects for stopped containers in version 3 and version 4 respectively. This currently causes the parser to fail

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Added test

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@tustvold tustvold requested a review from a team as a code owner June 4, 2025 12:08
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Jun 4, 2025
@pront pront changed the title fix(aws_ecs_metrics): skip over empty ECS metrics payloads fix(aws_ecs_metrics source): skip over empty ECS metrics payloads Jun 11, 2025
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold! Please add a fix changelog since this is a user facing change.

@pront pront added the source: aws_ecs_metrics Anything `aws_ecs_metrics` source related label Jun 11, 2025
@pront pront enabled auto-merge June 12, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources source: aws_ecs_metrics Anything `aws_ecs_metrics` source related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants