Skip to content

fix(aws_s3 source): Report SQS fetch errors as warnings #23044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yalinglee
Copy link
Contributor

Summary

This change reports an SQS fetch error (e.g. when a connection is dropped) as a warning instead of an error, since it will retry on the next poll interval.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

I ran make test SCOPE="sources::aws_s3" and all tests passed.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

@yalinglee yalinglee requested a review from a team as a code owner May 14, 2025 05:30
@yalinglee
Copy link
Contributor Author

@jszwedko Would you mind taking a look to see if the change in this PR is enough to make Vector report SQS fetch errors as warnings? Thank you!

@jszwedko jszwedko requested a review from pront May 22, 2025 18:20
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me since this the operation would be retried, but tagging @pront for review too.

@pront
Copy link
Member

pront commented Jun 10, 2025

Making SqsMessageReceiveError (emphasis on the Error) produce a warning sounds semantically awkward to me. Currently SqsMessageReceiveError is emitted in two places. Maybe you want to stop emitting it in once case and produce a warning there instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_s3 SQS fetch errors should be reported as warnings
3 participants