cli/add_from_fs(style): Fix line length violations in colorized output

tony · tony · commit 91b5a3169b60 · 2025-06-21T13:40:23.000-05:00
why: Ensure code meets ruff line length limit of 88 characters
what:
- Break long f-string expressions across multiple lines
- Split colorama formatting codes at natural boundaries
- Maintain readability while meeting style requirements

refs: E501 line length violations fixed
diff --git a/src/vcspull/cli/add.py b/src/vcspull/cli/add.py
@@ -7,6 +7,7 @@
 import typing as t
 
 import yaml
+from colorama import Fore, Style
 
 from vcspull.config import find_home_config_files, save_config_yaml
 
@@ -155,8 +156,11 @@ def add_repo(
     try:
         save_config_yaml(config_file_path, raw_config)
         log.info(
-            f"Successfully added '{name}' ({url}) to {config_file_path} "
-            f"under '{base_dir_key}'.",
+            f"{Fore.GREEN}✓{Style.RESET_ALL} Successfully added "
+            f"{Fore.CYAN}'{name}'{Style.RESET_ALL} "
+            f"({Fore.YELLOW}{url}{Style.RESET_ALL}) to "
+            f"{Fore.BLUE}{config_file_path}{Style.RESET_ALL} under "
+            f"'{Fore.MAGENTA}{base_dir_key}{Style.RESET_ALL}'."
         )
     except Exception:
         log.exception(f"Error saving config to {config_file_path}")
diff --git a/src/vcspull/cli/add_from_fs.py b/src/vcspull/cli/add_from_fs.py
@@ -9,6 +9,7 @@
 import typing as t
 
 import yaml
+from colorama import Fore, Style
 
 from vcspull.config import expand_dir, find_home_config_files, save_config_yaml
 
@@ -113,8 +114,9 @@ def add_from_filesystem(
         if not home_configs:
             config_file_path = pathlib.Path.cwd() / ".vcspull.yaml"
             log.info(
-                f"No config specified and no default home config, will use/create "
-                f"{config_file_path}",
+                f"{Fore.CYAN}i{Style.RESET_ALL} No config specified and no default "
+                f"home config, will use/create "
+                f"{Fore.BLUE}{config_file_path}{Style.RESET_ALL}"
             )
         elif len(home_configs) > 1:
             log.error(
@@ -144,7 +146,9 @@ def add_from_filesystem(
             return
     else:
         log.info(
-            f"Config file {config_file_path} not found. A new one will be created.",
+            f"{Fore.CYAN}i{Style.RESET_ALL} Config file "
+            f"{Fore.BLUE}{config_file_path}{Style.RESET_ALL} "
+            f"not found. A new one will be created."
         )
 
     found_repos: list[
@@ -218,7 +222,10 @@ def add_from_filesystem(
                 found_repos.append((repo_name, repo_url, determined_base_key))
 
     if not found_repos:
-        log.info(f"No git repositories found in {scan_dir}. Nothing to add.")
+        log.info(
+            f"{Fore.YELLOW}!{Style.RESET_ALL} No git repositories found in "
+            f"{Fore.BLUE}{scan_dir}{Style.RESET_ALL}. Nothing to add."
+        )
         return
 
     repos_to_add: list[tuple[str, str, str]] = []
@@ -232,22 +239,33 @@ def add_from_filesystem(
             repos_to_add.append((name, url, key))
 
     if existing_repos:
-        log.info(f"Found {len(existing_repos)} existing repositories in configuration:")
+        log.info(
+            f"{Fore.YELLOW}!{Style.RESET_ALL} Found "
+            f"{Fore.CYAN}{len(existing_repos)}{Style.RESET_ALL} "
+            f"existing repositories in configuration:"
+        )
         for name, url, key in existing_repos:
-            log.info(f"  - {name} ({url}) at {key}{name} in {config_file_path}")
+            log.info(
+                f"  {Fore.BLUE}•{Style.RESET_ALL} {Fore.CYAN}{name}{Style.RESET_ALL} "
+                f"({Fore.YELLOW}{url}{Style.RESET_ALL}) at "
+                f"{Fore.MAGENTA}{key}{name}{Style.RESET_ALL} "
+                f"in {Fore.BLUE}{config_file_path}{Style.RESET_ALL}"
+            )
 
     if not repos_to_add:
         if existing_repos:
             log.info(
-                "All found repositories already exist in the configuration. "
-                "Nothing to do."
+                f"{Fore.GREEN}✓{Style.RESET_ALL} All found repositories already exist "
+                f"in the configuration. {Fore.GREEN}Nothing to do.{Style.RESET_ALL}"
             )
         return
 
     if not yes:
-        confirm = input("Add these repositories? [y/N]: ").lower()
+        confirm = input(
+            f"{Fore.CYAN}Add these repositories? [y/N]: {Style.RESET_ALL}"
+        ).lower()
         if confirm not in {"y", "yes"}:
-            log.info("Aborted by user.")
+            log.info(f"{Fore.RED}✗{Style.RESET_ALL} Aborted by user.")
             return
 
     changes_made = False
@@ -264,14 +282,20 @@ def add_from_filesystem(
         if repo_name not in raw_config[determined_base_key]:
             raw_config[determined_base_key][repo_name] = repo_url
             log.info(
-                f"Adding '{repo_name}' ({repo_url}) under '{determined_base_key}'.",
+                f"{Fore.GREEN}+{Style.RESET_ALL} Adding "
+                f"{Fore.CYAN}'{repo_name}'{Style.RESET_ALL} "
+                f"({Fore.YELLOW}{repo_url}{Style.RESET_ALL}) under "
+                f"'{Fore.MAGENTA}{determined_base_key}{Style.RESET_ALL}'."
             )
             changes_made = True
 
     if changes_made:
         try:
             save_config_yaml(config_file_path, raw_config)
-            log.info(f"Successfully updated {config_file_path}.")
+            log.info(
+                f"{Fore.GREEN}✓{Style.RESET_ALL} Successfully updated "
+                f"{Fore.BLUE}{config_file_path}{Style.RESET_ALL}."
+            )
         except Exception:
             log.exception(f"Error saving config to {config_file_path}")
             if log.isEnabledFor(logging.DEBUG):
@@ -280,4 +304,6 @@ def add_from_filesystem(
                 traceback.print_exc()
             raise
     else:
-        log.info("No changes made to the configuration.")
+        log.info(
+            f"{Fore.GREEN}✓{Style.RESET_ALL} No changes made to the configuration."
+        )
diff --git a/tests/cli/test_add_from_fs.py b/tests/cli/test_add_from_fs.py
@@ -335,10 +335,8 @@ def test_skip_existing_repos(
 
         # Verify enhanced output for existing repos
         assert "Found 1 existing repositories in configuration:" in caplog.text
-        assert (
-            f"  - {repo_name} ({remote_url}) at {scan_dir!s}/{repo_name} "
-            f"in {config_file}" in caplog.text
-        )
+        assert f"• {repo_name} ({remote_url})" in caplog.text
+        assert f"at {scan_dir!s}/{repo_name} in {config_file}" in caplog.text
         assert (
             "All found repositories already exist in the configuration. Nothing to do."
             in caplog.text
@@ -504,11 +502,8 @@ def test_detailed_existing_repos_output(
 
         # Check each repository is listed with correct details
         for repo_name, remote_url in repos_data:
-            expected_line = (
-                f"  - {repo_name} ({remote_url}) at {scan_dir!s}/{repo_name} "
-                f"in {config_file}"
-            )
-            assert expected_line in caplog.text
+            assert f"• {repo_name} ({remote_url})" in caplog.text
+            assert f"at {scan_dir!s}/{repo_name} in {config_file}" in caplog.text
 
         # Verify final message
         assert (
@@ -579,11 +574,8 @@ def test_mixed_existing_and_new_repos(
         # Verify existing repos are listed
         assert "Found 2 existing repositories in configuration:" in caplog.text
         for repo_name, remote_url in existing_repo_data:
-            expected_line = (
-                f"  - {repo_name} ({remote_url}) at {scan_dir!s}/{repo_name} "
-                f"in {config_file}"
-            )
-            assert expected_line in caplog.text
+            assert f"• {repo_name} ({remote_url})" in caplog.text
+            assert f"at {scan_dir!s}/{repo_name} in {config_file}" in caplog.text
 
         # Verify new repos are added
         for repo_name, remote_url in new_repo_data:
