Skip to content

Commit 897f8a4

Browse files
committed
tests/log(feat[sync-logger-tests]): Add comprehensive tests for CLI sync logger
why: Ensure CLI sync logger is properly configured with SimpleLogFormatter what: - Add test_setup_logger_creates_cli_sync_logger test case - Update logger cleanup fixture to include sync logger - Update all setup_logger tests to clear sync logger handlers - Verify sync logger uses SimpleLogFormatter for clean output
1 parent 75fd9ef commit 897f8a4

File tree

1 file changed

+34
-0
lines changed

1 file changed

+34
-0
lines changed

tests/test_log.py

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ def cleanup_loggers() -> t.Iterator[None]:
3131
"vcspull",
3232
"vcspull.cli.add",
3333
"vcspull.cli.add_from_fs",
34+
"vcspull.cli.sync",
3435
"libvcs",
3536
"test_logger",
3637
"", # Root logger
@@ -452,6 +453,7 @@ def test_setup_logger_custom_level(self, caplog: LogCaptureFixture) -> None:
452453
"vcspull",
453454
"vcspull.cli.add",
454455
"vcspull.cli.add_from_fs",
456+
"vcspull.cli.sync",
455457
"libvcs",
456458
]:
457459
logger = logging.getLogger(logger_name)
@@ -474,6 +476,7 @@ def test_setup_logger_creates_vcspull_logger(
474476
"vcspull",
475477
"vcspull.cli.add",
476478
"vcspull.cli.add_from_fs",
479+
"vcspull.cli.sync",
477480
"libvcs",
478481
]:
479482
logger = logging.getLogger(logger_name)
@@ -500,6 +503,7 @@ def test_setup_logger_creates_cli_add_logger(
500503
"vcspull",
501504
"vcspull.cli.add",
502505
"vcspull.cli.add_from_fs",
506+
"vcspull.cli.sync",
503507
"libvcs",
504508
]:
505509
logger = logging.getLogger(logger_name)
@@ -526,6 +530,7 @@ def test_setup_logger_creates_cli_add_fs_logger(
526530
"vcspull",
527531
"vcspull.cli.add",
528532
"vcspull.cli.add_from_fs",
533+
"vcspull.cli.sync",
529534
"libvcs",
530535
]:
531536
logger = logging.getLogger(logger_name)
@@ -542,6 +547,33 @@ def test_setup_logger_creates_cli_add_fs_logger(
542547
handler = add_fs_logger.handlers[0]
543548
assert isinstance(handler.formatter, SimpleLogFormatter)
544549

550+
def test_setup_logger_creates_cli_sync_logger(
551+
self, caplog: LogCaptureFixture
552+
) -> None:
553+
"""Test that setup_logger creates CLI sync logger."""
554+
# Clear handlers first to avoid interference
555+
root_logger = logging.getLogger()
556+
for logger_name in [
557+
"vcspull",
558+
"vcspull.cli.add",
559+
"vcspull.cli.add_from_fs",
560+
"vcspull.cli.sync",
561+
"libvcs",
562+
]:
563+
logger = logging.getLogger(logger_name)
564+
logger.handlers.clear()
565+
root_logger.handlers.clear()
566+
567+
setup_logger(level="INFO")
568+
569+
sync_logger = logging.getLogger("vcspull.cli.sync")
570+
assert len(sync_logger.handlers) > 0
571+
assert sync_logger.propagate is False
572+
573+
# Test that it uses SimpleLogFormatter
574+
handler = sync_logger.handlers[0]
575+
assert isinstance(handler.formatter, SimpleLogFormatter)
576+
545577
def test_setup_logger_creates_libvcs_logger(
546578
self, caplog: LogCaptureFixture
547579
) -> None:
@@ -552,6 +584,7 @@ def test_setup_logger_creates_libvcs_logger(
552584
"vcspull",
553585
"vcspull.cli.add",
554586
"vcspull.cli.add_from_fs",
587+
"vcspull.cli.sync",
555588
"libvcs",
556589
]:
557590
logger = logging.getLogger(logger_name)
@@ -595,6 +628,7 @@ def test_setup_logger_with_none_creates_root_logger(
595628
"vcspull",
596629
"vcspull.cli.add",
597630
"vcspull.cli.add_from_fs",
631+
"vcspull.cli.sync",
598632
"libvcs",
599633
]:
600634
logger = logging.getLogger(logger_name)

0 commit comments

Comments
 (0)