Refactor: Create backups of keys #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ojuswi Rastogi <ojuswimail@gmail.com>
OjusWiZard
commented
Jun 6, 2025
| migrated = False | ||
| backup_path = path.with_suffix(".bak") | ||
| if not backup_path.is_file(): | ||
| shutil.copyfile(path, backup_path) |
There was a problem hiding this comment.
@kalraash I Need a second opinion, that this method of copying file should not corrupt the original file, even if the process is killed in between, right?
There was a problem hiding this comment.
This looks fine @OjusWiZard as shutil function never modifies or locks the original file. Even if the process is terminated mid-copy, only the destination file (backup_path) is at risk of being incomplete or corrupted.
5 tasks
jmoreira-valory
approved these changes
Jun 16, 2025
kalraash
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is to make the keys safe, so that any possibility of corruption from the read operations can be dealt using the backups.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply