Skip to content

Conversation

akx
Copy link
Member

@akx akx commented Oct 14, 2025

Required for supporting library steps

@akx akx requested review from a team, Copilot, teroyks and tokkoro and removed request for a team October 14, 2025 08:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for specifying a commit in execution and task node definitions to enable library steps functionality. This allows pipeline nodes to reference steps from different commits or external libraries rather than only the current project's steps.

  • Added commit property to execution and task node schemas and implementations
  • Refactored schema definitions to eliminate code duplication between execution and task nodes
  • Updated linting logic to skip step validation when a commit is specified

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
valohai_yaml/schema_data.py Refactored schema definitions and added commit property support
valohai_yaml/objs/pipelines/execution_node.py Added commit parameter and updated linting logic
tests/test_pipeline.py Added test for pipeline with commit functionality
tests/conftest.py Added test fixture for commit-based pipeline
tests/snapshots/test_validation.ambr Updated error message formatting with quotes
examples/pipeline-with-different-commit.yaml Added example configuration showing commit usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

) -> None:
super().__init__(name=name, actions=actions, on_error=on_error)
self.step = step
self.commit = str(commit) if commit else None
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting commit to string when it's not None could cause issues if commit is already a string or if it's an unexpected type. Consider using self.commit = commit directly since the type hint indicates it should be Optional[str].

Suggested change
self.commit = str(commit) if commit else None
self.commit = commit

Copilot uses AI. Check for mistakes.

Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks simple enough, the more complex part is the other side of the implementation 😆

@ruksi ruksi merged commit ecc0b13 into master Oct 14, 2025
7 checks passed
@ruksi ruksi deleted the node-commit branch October 14, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants