Skip to content

Conversation

akx
Copy link
Member

@akx akx commented May 23, 2025

Rehashes @drazendee's PR from 2022, now with rebasing and tests!

Closes #251 (supersedes it)

@akx akx force-pushed the project-envvars-2025 branch 2 times, most recently from c819c95 to 651a9a5 Compare May 23, 2025 12:14
@akx akx force-pushed the project-envvars-2025 branch 2 times, most recently from ac64256 to 905b42d Compare May 23, 2025 12:17
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 97.24771% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.54%. Comparing base (d6ffdfb) to head (8495f8e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...i/commands/project/environment_variables/delete.py 90.00% 1 Missing and 1 partial ⚠️
...cli/commands/project/environment_variables/list.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   86.30%   86.54%   +0.24%     
==========================================
  Files         133      138       +5     
  Lines        4716     4824     +108     
  Branches      605      616      +11     
==========================================
+ Hits         4070     4175     +105     
- Misses        452      454       +2     
- Partials      194      195       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akx akx force-pushed the project-envvars-2025 branch 2 times, most recently from 29b2193 to 3056133 Compare May 23, 2025 12:27
@akx akx mentioned this pull request May 23, 2025
@akx akx requested review from a team, dangquangdon and teroyks and removed request for a team May 23, 2025 20:09
@akx akx enabled auto-merge (squash) May 23, 2025 20:10
@akx akx force-pushed the project-envvars-2025 branch 3 times, most recently from eb97f4b to b1f68fe Compare May 26, 2025 05:32
Co-authored-by: Aarni Koskela <akx@iki.fi>
@akx akx force-pushed the project-envvars-2025 branch from b1f68fe to 8495f8e Compare May 26, 2025 05:58
@akx akx requested a review from teroyks May 26, 2025 05:59
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akx akx merged commit 3736a14 into master May 26, 2025
10 checks passed
@akx akx deleted the project-envvars-2025 branch May 26, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants