Skip to content

Conversation

teroyks
Copy link
Contributor

@teroyks teroyks commented May 23, 2025

Click v8.2 introduces some changes that break tests, especially where git operations are monkeypatched: it produces the following extra warning output:

Warning: The directory is not a Git repository. 
Would you like to just run using the latest commit known by Valohai?
Use latest commit? [Y/n]:Aborted!

Naturally, this breaks the tests that check the output for expected test.

Temporarily fixed by pinning click to a version below 8.2.


Also update setup-uv to v6 while at it (unrelated, but left there since it was already there due to earlier testing).

Just testing if this would have any effect with running the tests...
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (ea1d7fa) to head (6c0cec9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         129      129           
  Lines        4676     4676           
  Branches      605      605           
=======================================
  Hits         4030     4030           
  Misses        452      452           
  Partials      194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teroyks teroyks force-pushed the tero/setup-uv/upgrade-to-v6 branch from f858bf9 to fc25d14 Compare May 23, 2025 10:31
@teroyks teroyks force-pushed the tero/setup-uv/upgrade-to-v6 branch from 316066e to 6c0cec9 Compare May 23, 2025 11:11
@teroyks teroyks changed the title Update setup-uv to the latest version (v6) Pin Click to latest version that does not break tests May 23, 2025
@teroyks teroyks marked this pull request as ready for review May 23, 2025 11:16
@teroyks teroyks self-assigned this May 23, 2025
@teroyks teroyks added dependencies Pull requests that update a dependency file type:infra Refactorings etc. labels May 23, 2025
@teroyks teroyks requested review from akx and ruksi May 23, 2025 11:17
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a pin in it for now!

@teroyks teroyks merged commit f2e0024 into master May 23, 2025
9 checks passed
@akx
Copy link
Member

akx commented May 23, 2025

(See pallets/click#2522 in Click.)

@teroyks teroyks deleted the tero/setup-uv/upgrade-to-v6 branch May 23, 2025 11:17
@teroyks teroyks changed the title Pin Click to latest version that does not break tests 📌 Pin Click to latest version that does not break tests May 23, 2025
@teroyks teroyks changed the title 📌 Pin Click to latest version that does not break tests 📌 Pin Click to latest version that does not break tests May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file type:infra Refactorings etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants