Skip to content

Conversation

akx
Copy link
Member

@akx akx commented Sep 5, 2025

Stacked on top of #41.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.00%. Comparing base (d4d9b9d) to head (f2295c5).

Files with missing lines Patch % Lines
minique/types.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   90.58%   92.00%   +1.41%     
==========================================
  Files          27       27              
  Lines        1041     1050       +9     
  Branches       80       80              
==========================================
+ Hits          943      966      +23     
+ Misses         65       53      -12     
+ Partials       33       31       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akx akx force-pushed the valkey branch 2 times, most recently from 5c2d7b2 to e1efc37 Compare September 5, 2025 13:00
@akx akx changed the title Valkeyness Drop hard dependency on redis-py; test on Valkey too Sep 5, 2025
@akx akx marked this pull request as ready for review September 29, 2025 05:38
@akx akx requested a review from Copilot September 29, 2025 05:38
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the hard dependency on redis-py by making it an optional dependency, while adding support for Valkey as an alternative Redis-compatible client. The changes enable users to choose between redis-py or valkey-py clients.

Key changes:

  • Converts redis dependency from required to optional with separate [redis] and [valkey] extras
  • Introduces generic RedisClient type alias to support both client libraries
  • Updates CLI to auto-detect and prefer Valkey client when available
  • Adds comprehensive test coverage for both Redis and Valkey client/server combinations

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Moves redis dependency to optional extras, adds valkey option
minique/types.py Defines RedisClient type alias for client abstraction
minique/cli.py Implements client auto-detection logic with Valkey preference
minique_tests/conftest.py Updates test fixture to use new client detection
minique/work/job_runner.py Replaces isinstance check with duck typing
.github/workflows/ci.yml Adds matrix testing for Redis/Valkey client/server combinations
README.md Updates documentation to reflect Redis/Valkey support
Various test files Updates type annotations from Redis to RedisClient

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@akx akx requested review from a team, ruksi and teroyks and removed request for a team October 1, 2025 08:16
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valkey support, yay

@ruksi
Copy link
Member

ruksi commented Oct 3, 2025

the branch protection rules had old CI actions, change to the following based on that the old ones were 3.10 and 3.13

edit as needed!

image

@ruksi ruksi merged commit 1bb5e7e into master Oct 3, 2025
20 checks passed
@ruksi ruksi deleted the valkey branch October 3, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants