Skip to content

Conversation

akx
Copy link
Member

@akx akx commented Mar 19, 2025

I couldn't quite test these "in vivo" on my Mac, so @ruksi, if you'd give it the good old tire-kick too?

But hey, we're now .clone() free!

@akx akx requested a review from ruksi March 19, 2025 07:15
@akx akx marked this pull request as ready for review March 19, 2025 07:18
@ruksi
Copy link
Member

ruksi commented Mar 19, 2025

I couldn't quite test these "in vivo" on my Mac, so @ruksi, if you'd give it the good old tire-kick too?

But hey, we're now .clone() free!

sure thing! I can run it against local, v1 and v2 setups

@ruksi
Copy link
Member

ruksi commented Mar 19, 2025

yup yup, works the same!

2025-03-19_10-59-23

Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great changes all around, looks much cleaner with the source priority being defined before the loop 🎉

I fixed a minor Clippy warning:

warning: this lifetime isn't used in the function definition
  --> src/utils.rs:19:30
   |
19 | pub fn get_path_or_croak<'a, 'b>(
   |                              ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

but other than that, gtg!

@akx akx merged commit 626f69a into main Mar 19, 2025
5 checks passed
@akx akx deleted the sim branch March 19, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants